1039067 - Submitted a packaged app against marketplace-dev fails and throws a 500 Internal Server Error

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P1)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

test_packaged_app_submission[1] fails[2] (submitting a packaged app against https://marketplace-dev.allizom.org/developers/submit/, and hits a 500 along the way (I don't have the stacktrace, yet).  HTML Report in [3], below.

FWIW, this still works on staging, and last worked this morning on dev[4] at 5:30am (big window, I know, sorry!)


[1] https://github.com/mozilla/marketplace-tests/blob/master/tests/desktop/developer_hub/test_developer_hub_submit_apps.py#L20
[2] http://saucelabs.com/jobs/c3e5cc2261284a448ac9b1bc98daea8b
[3] http://selenium.qa.mtv2.mozilla.com:8080/job/marketplace.dev.developer_hub.saucelabs/1230/HTML_Report/
[4] http://selenium.qa.mtv2.mozilla.com:8080/job/marketplace.dev.developer_hub.saucelabs/1227/HTML_Report/

Comment 1

[Rob Hudson [:robhudson]]

It seems to have broken from this commit:
https://github.com/mozilla/zamboni/commit/e7a4ca3d

Assigning to Mark.

Traceback (from my local machine):
Traceback (most recent call last):
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/wsgiref/handlers.py", line 85, in run
    self.result = application(self.environ, self.start_response)
  File "/Users/rob/.virtualenvs/zamboni/lib/python2.7/site-packages/django/core/handlers/wsgi.py", line 206, in __call__
    response = self.get_response(request)
  File "/Users/rob/.virtualenvs/zamboni/lib/python2.7/site-packages/django/core/handlers/base.py", line 194, in get_response
    response = self.handle_uncaught_exception(request, resolver, sys.exc_info())
  File "/Users/rob/.virtualenvs/zamboni/lib/python2.7/site-packages/django/core/handlers/base.py", line 112, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/Users/rob/git/zamboni/apps/amo/decorators.py", line 165, in wrapper
    return f(*args, **kw)
  File "/Users/rob/git/zamboni/apps/amo/decorators.py", line 152, in __call__
    return self.f(*args, **kw)
  File "/Users/rob/git/zamboni/mkt/submit/views.py", line 59, in submit
    return manifest(request)
  File "/Users/rob/git/zamboni/apps/amo/decorators.py", line 32, in wrapper
    return func(request, *args, **kw)
  File "/Users/rob/git/zamboni/mkt/submit/decorators.py", line 37, in wrapper
    return f(request, *args, **kw)
  File "/Users/rob/git/zamboni/mkt/submit/decorators.py", line 21, in wrapper
    return f(request, *args, **kw)
  File "/Users/rob/git/zamboni/mkt/submit/views.py", line 118, in manifest
    addon, validation, addon.current_version)
  File "/Users/rob/git/zamboni/mkt/developers/utils.py", line 166, in escalate_prerelease_permissions
    permissions = set(app_permissions)
TypeError: 'bool' object is not iterable

Comment 3

[Christopher Van Wiemeersch [:cvan]]

See comment 0 of bug 1039202 for STR

Comment 4

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/zamboni/pull/2326

Comment 5

[Viorela Ioia [:viorela]]

This is also happening on stage now.
I will xfail the test until we fix the issue.

Comment 6

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/zamboni/commit/99b36c5d1fd996fda7a2990ce084e4ed7f24436b

Comment 7

[krupa raj[:krupa]]

verified @ https://marketplace-dev.allizom.org/developers/submit/details/test-webapi-permissions-13

fixed on both dev and stage.