Closed Bug 1039163 Opened 10 years ago Closed 10 years ago

Remove the CSS transition delay for key popup and highlights

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.1 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g-v2.1 --- fixed

People

(Reporter: rudyl, Assigned: rudyl)

Details

Attachments

(1 file)

Patch V1
46 bytes, text/x-github-pull-request
timdream
: review+
drs
: feedback+
Details | Review 
This basically reverts the changes we made in bug 971446, since the same effect (to display the popup longer) has been re-implemented in bug 957031.

--
BTW, this should also fix an issue that when you tap on the [space key], you will see the popup for a short time after the release the key.
Attached file Patch V1 — 
Tim,

Could you help review this?

Doug,

As described in comment 0, this basically remove the changes you did in Bug 971446, so asking for feedback from you.
Attachment #8456800 - Flags: review?(timdream)
Assignee: nobody → rlu
Status: NEW → ASSIGNED
Attachment #8456800 - Flags: review?(timdream) → review+
Comment on attachment 8456800 [details] [review]
Patch V1

It seems I forgot to set the feedback.
Attachment #8456800 - Flags: feedback?(drs+bugzilla)
Comment on attachment 8456800 [details] [review]
Patch V1

Cool, I'm glad this was done better.
Attachment #8456800 - Flags: feedback?(drs+bugzilla) → feedback+
Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/28a2312b97c328ac457e2f6cd8b8267e7e159a93
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.1: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: