Closed
Bug 1039245
Opened 10 years ago
Closed 10 years ago
[NFC] Move NDEF record payload parsing from NfcManager and expose it to app developers
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(b2g-v2.1 fixed)
RESOLVED
FIXED
2.1 S1 (1aug)
Tracking | Status | |
---|---|---|
b2g-v2.1 | --- | fixed |
People
(Reporter: tauzen, Assigned: tauzen)
References
Details
Attachments
(1 file)
When NfcManager receives an NDEF message it parses the first record of the message and triggers the appropriate activity according to parsing result. NfcManager has several helper methods for different types of NDEF records, each of this methods performs suitable parsing and prepares options for activity to be launched.
We should introduce an utility method which would parse NDEF record payload according to it's tnf and type. This method will be used by NfcManager the determine which activity should be triggered.
This method will be also used by app developers to get the payload of other NDEF records from NDEF message. So they won't need to write the payload parsing code for common records themselves.
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 1•10 years ago
|
||
Hi Greg, could you review this? There's a couple of changes here, so if you have any questions just let me know.
Attachment #8464498 -
Flags: review?(gweng)
Comment 2•10 years ago
|
||
Comment on attachment 8464498 [details] [review]
pull-request-1039245.txt
Hello, I think the patch is fine while the major change is to move the code around. Please fix the nits or comment on them and then checkin-needed.
Attachment #8464498 -
Flags: review?(gweng) → review+
Assignee | ||
Comment 3•10 years ago
|
||
I've rebased the patch and fixed the comments from github as requested. Thanks for the review!
Keywords: checkin-needed
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → 2.1 S1 (1aug)
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.1:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•