1039441 - The Loop Client is not usable if you don't share the app permissions

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[mbarone]

Attachment: 2014-07-16-09-19-31.png

Loop Commit: cae484ed0c02a74c59d36c55e6798be120ad22d2

STR
1. Open Loop client for the first time
2. Follow the wizard until the dialog "App permission" (see attached file)
3. Select Remember my choice and click on Don't share

ACTUAL RESULT
The app shows the last dialog of the wizard and the user can't perform any action. IF you kill the app, you still can't perform any action. In order to use the Loop client you need to go to settings and change the permissions.

Comment 1

[Maria Angeles Oteo (:oteo)]

It depends on bug 1046170, when the permissions screen is eliminated from the wizard the problem should disappear. Confirm when Bug 1046170 is fixed.

Comment 2

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue no longer occurs on the latest 2.0 build with the v165 KK base.  The user is still asked about sharing the camera (not the microphone), but regardless of the choice made the app can be navigated and calls can be made.

Environmental Variables:
Device: Flame 2.0
BuildID: 20140820030000
Gaia: 806d37a264743e04a3e1493136486f3e00124e1e
Gecko: 6329352ca531b977979451e77e5862af485388b2
Version: 32.0 (2.0) 
Firmware Version: v165
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Loop version: 8c71431

Comment 3

[Borja Salguero [:borjasalguero]]

In this case, the worst scenario is if the user is rejecting the permission, and tapping on the 'remember' checkbox. In this case, we must show a prompt explaining to the user the scenario, and the option of fixing this through the Settings App. Taking this and I'll upload a patch soon!

Comment 4

[Maria Angeles Oteo (:oteo)]

Rafa, Pau, regarding comment 3, we need a message in case the user rejects the permission. Please, note that the application can not know if the user has selected the "Remember my permissions" checkbox or not so the string should be generic for both situations.

Comment 5

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Comment 6

[Rafael Rebolleda]

A little tweak:

EN: "We can't access your microphone and camera because you didn't give us permission. To use <ServiceName>, please grant them in Settings > App permissions > <ServiceName>"

ES: "No tenemos acceso al micrófono ni la cámara porque no nos diste permiso. Para usar <ServiceName>, por favor cambia estos permisos en Ajustes > Permisos de aplicaciones > <ServiceName>"

Comment 7

[Borja Salguero [:borjasalguero]]

Patch updated with latest strings.

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8479051 [details] [review]
Pull Request

Looking good. IMHO, according to the call set up protocol, we should send the terminated media-fail call set up message to the server. Lets add this and land the bug.

Comment 9

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8479051 [details] [review]
Pull Request

LGTM. r=me

Thanks Borja!

Comment 10

[mbarone]

Tested with Flame (v2.0 kk v180)
Gecko-9362b48.Gaia-6449cc3
Loop version 041ff17