1039548 - pressing enter causes a form submit if a radio button is selected and there are no text/number inputs in the form

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Alessio]

Attachment: test.html

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 SeaMonkey/2.26.1 (Beta/Release)
Build ID: 20140612174402

Steps to reproduce:

- open the attached test.html
- click on a radio button
- press the enter key


Actual results:

- the form is being submitted


Expected results:

I think the form should not be submitted, at least it does not submit in Chrome and in Internet Explorer (on these browsers pressing enter causes the radio button to be focused).
Also up to Firefox 26 the form is not being submitted, so this behavior changed starting from version 27 and is still present in version 30.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Hmm.  This is the behavior I see on Mac:

1)  Click on the radio button followed by hitting enter does not submit the form.
2)  Tabbing to the radio button followed by hitting enter does submit the form.

We didn't use to do #2 in 26, indeed.  Looks like the behavior changed in this range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9f63bbc00527&tochange=423b9c30c73d

I think this is a regression from bug 927365.  The old behavior was to disable implicit submission unless there was exactly one text input; the new behavior is to disable if there are fewer than 2.  In particular, in the case of 0 text inputs there used to be no implicit submission, but that got changed.  Was that purposeful?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

No.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=f2480d43576d

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8461781 [details] [diff] [review]
patch

r=me

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3208f341b926

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3208f341b926

Comment 7

[Gabriela [:gaby2300]]

I can verify it's fixed using Windows 7 64 bit and the latest Beta.

Comment 8

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Thank you Gabriela!