1040158 - Need a way to override multiprocessCompatible flag in install.rdf (AMO control for e10s-breaking add-ons)

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

+++ This bug was initially created as a clone of Bug #1029926 +++

Blair asked for some follow-up work to bug 1029926, which added the multiprocessCompatible flag to install.rdf:

In addition to supporting this flag in install.rdf, we'll also want a followup bug to let AMO override it. This will let us cover cases like:
* Add-on is multi-process compatible, but author didn't add multiprocessCompatible to install.rdf
* Add-on specifies multiprocessCompatible, but we find it's buggy and needs the shims afterall
* Something changes that makes an add-on that was once multi-process compatible now be broken and need shims

And, finally, we should have some telemetry added for this, so we know what impact it's having now and over time.

Comment 1

[Chris Peterson [:cpeterson]]

Needs both client side and AMO side work.

Comment 2

[Dave Townsend [:mossop]]

I can't see how this depends on bug 1083545

Comment 3

[Dave Townsend [:mossop]]

I'm splitting the telemetry piece of this off into bug 1128121

Comment 4

[Dave Townsend [:mossop]]

Attachment: patch

This allows an update.rdf to override the multiprocessCompatible. It doesn't do this at install time since we don't always load the update.rdf then (perhaps we should). But whenever a daily update check happens the change will be applied and persisted. The format is simple, with no flag present in update.rdf no change happens. If the flag is set then its value overrides that of install.rdf.

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to Dave Townsend [:mossop] from comment #4)
> It doesn't
> do this at install time since we don't always load the update.rdf then
> (perhaps we should).

Yea, have been thinking we should.

Comment 6

[Dave Townsend [:mossop]]

https://hg.mozilla.org/integration/fx-team/rev/3c49c72bbd26

(In reply to Blair McBride [:Unfocused] (I don't read bugmail - needinfo? me!) from comment #5)
> (In reply to Dave Townsend [:mossop] from comment #4)
> > It doesn't
> > do this at install time since we don't always load the update.rdf then
> > (perhaps we should).
> 
> Yea, have been thinking we should.

Filed bug 1129479

Comment 7

[Dave Townsend [:mossop]]

Backed out for test failures: https://hg.mozilla.org/integration/fx-team/rev/584d995002a6

Comment 8

[Dave Townsend [:mossop]]

Relanded with the braindead simple initialisation order change in the test: https://hg.mozilla.org/integration/fx-team/rev/d0d66a5cad38

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d0d66a5cad38