1040598 - Move keyboard states out of keyboard.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

With bug 1035062, the keyboard.js now contains 600 lines and mostly are logic involving starting the app and loading/switch between different layout and im engines.

The keyboard show/hide state would need yet another manager module, and LayoutManager and InputMethodManager can bear more responsibilities on loading layout/IMEngine. I am not sure about the line to drawn though.

This bug ideally should make keyboard.js contains fewer than 10 lines, basically just

window.app = new KeyboardApp(); app.start();

If the patch turned out to be too big we can always clone another bug and follow-up.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

With bug 1041411, the requirement of this bug need to updated to simply removing keyboard.js, since the bootstrap part has moved to it's own script too.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Upon looking into the code a bit, I realized it make more sense for me to take this bug and finish what I have started.

The plan now is to create a StateManager and a LayoutRenderingManager to finally move all non-trivial logic to where they belong, and delete the file.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I will be able to submit for review today or tomorrow once all unit tests are written.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The patch happen to overlap with what Rudy is doing in bug 1020779, so this should wait.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Github: https://github.com/mozilla-b2g/gaia/pull/22291

This patch removes keyboard.js for good with it's remaining responsibility moved to StateManager, LayoutRenderingManager, and elsewhere.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8464474 [details] [review]
Github: https://github.com/mozilla-b2g/gaia/pull/22291

This looks pretty good to me with only some nits.
r=me.

Thank you.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/76df34a5c18afd0bb68a37617e1f4adc6ff15d4e

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

CI result: 

https://tbpl.mozilla.org/?rev=c87bb780322b762ab984251d98a36a6d764c4321&tree=Gaia-Try