1040599 - On translation, remove checkbox making a page a KumaScript template (macro)

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Localization, defect, P3)

Description

[Jean-Yves Perrier [:teoli]]

Attachment: Screen Shot 2014-07-18 at 08.43.29.png

This is a leftover from bug 1032058.

KumaScript macros (templates) must not be translated. Instead of translating the strings inside the generic macros, we have users creating new macros in the translated domain and toggling this flag.

Just removing the checkbox at the bottom of the translation interface (only) will solve this problem. Of course the two others checkbox must be kept.

In the screenshot, the checkbox is labeled "Modèle — code KumaScript" (French translation)

Comment 1

[David Walsh :davidwalsh]

@ubernostrum:

https://github.com/mozilla/kuma/blob/master/apps/wiki/templates/wiki/includes/review_tags.html

Can we add something to model which will place an intelligent "id" attribute on each tag's LI element?  Or do I have to make this template more complicated and loop through each tag, manually building the HTML?

Comment 2

[James Bennett [:ubernostrum]]

(In reply to David Walsh :davidwalsh from comment #1)
> Can we add something to model which will place an intelligent "id" attribute
> on each tag's LI element?  Or do I have to make this template more
> complicated and loop through each tag, manually building the HTML?

I suspect this is going to involve fiddling with the template and/or with the form code; if you can show me an example of the HTML you want, I can give a better idea of where and how to do it.

Comment 3

[David Walsh :davidwalsh]

Now it's:

<ul>
<li><label for="id_review_tags_0"><input name="review_tags" value="technical" id="id_review_tags_0" type="checkbox"> Technical - code samples, APIs, or technologies</label></li>
<li><label for="id_review_tags_1"><input name="review_tags" value="editorial" id="id_review_tags_1" type="checkbox"> Editorial - prose, grammar, or content</label></li>
<li><label for="id_review_tags_2"><input name="review_tags" value="template" id="id_review_tags_2" type="checkbox"> Template - KumaScript code</label></li>
</ul>

I'd prefer:

<ul>
<li id="review_tag_technical"><label for="id_review_tags_0"><input name="review_tags" value="technical" id="id_review_tags_0" type="checkbox"> Technical - code samples, APIs, or technologies</label></li>
<li id="review_tag_editorial"><label for="id_review_tags_1"><input name="review_tags" value="editorial" id="id_review_tags_1" type="checkbox"> Editorial - prose, grammar, or content</label></li>
<li id="review_tag_template"><label for="id_review_tags_2"><input name="review_tags" value="template" id="id_review_tags_2" type="checkbox"> Template - KumaScript code</label></li>
</ul>

IDEALLY, however, there would be a way to call the form with a flag so that the last list item wouldn't be rendered at all.  Lemme know!

Comment 4

[James Bennett [:ubernostrum]]

Blech. This is more complicated than I was thinking it would be. :davidwalsh, do you have time today or tomorrow to chat live about this?

Comment 5

[Florian Scholz (Open Web Docs)]

Do we need the checkbox at all?

If you look at a real template/macro (https://developer.mozilla.org/en-US/docs/Template:SpecName), it is unchecked there as well...

I think templates are templates because of their "Template:xxx" namespace and not because of this flag. So, what is flag for and why can't we get rid of it completely?

Comment 6

[Eric Shepherd [:sheppy]]

This checkbox and the flag it's hooked to were never used for anything.

Comment 7

[Trevor]

https://developer.mozilla.org/en-US/docs/needs-review/template uses that flag.

It was certainly used during the migration process http://www.bitstampede.com/2012/06/25/help-us-convert-templates-to-kumascript/ , number 6 on the list.

The list of templates still with the flag set look mainly like ones that actually need to be reviewed. Probably a task for sheppy, so unused and un-useful ones can be deleted and bugs raised to fix the broken useful ones.

I don't believe the flag should be ever have been applied to document pages.

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/0f0dc79f553bdce75c7dde0582050d4f5e06e4a2
fix bug 1040599 - Remove unnecessary review flag

https://github.com/mozilla/kuma/commit/3ff5276dcabb8722266631e54195d509f8debabc
Merge pull request #2650 from darkwing/translate-template-1040599

fix bug 1040599 - Remove unnecessary review flag