1040651 - [LayerScope] Add a "LayerScope" option in "Settings -> Developer"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Boris Chiou [:boris]]

I think we should add a "LayerScope" option in Settings->Developer to enable/disable the preference of LayerScope, so we don't need to run ./edit-prefs.sh on B2G and add:
1. user_pref("gfx.layerscope.enabled", true);
2. user_pref("network.gonk.manage-offline-status", false);

Comment 1

[Boris Chiou [:boris]]

Attachment: Gacko Part. (v1)

Add a listener at Gecko side. We will also add a "LayerScope" option
in "Settings -> Developer", so we can enable Layerscope dynamically.

Comment 2

[Boris Chiou [:boris]]

Attachment: Gaia Part. (v1) (pull request #25976)

Comment 3

[Boris Chiou [:boris]]

I think we only need "gfx.layerscope.enabled" for enabling layerscope right now, so I will only add an option for "gfx.layerscope.enabled" in my patch. Thanks.

Comment 4

[Boris Chiou [:boris]]

(In reply to Boris Chiou [:boris] from comment #2)
> Created attachment 8519648 [details] [review]
> Gaia Part. (v1) (pull request #25976)

(In reply to Boris Chiou [:boris] from comment #1)
> Created attachment 8519642 [details] [diff] [review]
> Gacko Part. (v1)
> 
> Add a listener at Gecko side. We will also add a "LayerScope" option
> in "Settings -> Developer", so we can enable Layerscope dynamically.

Try server:
https://tbpl.mozilla.org/?tree=Try&rev=72fadac31512

Comment 5

[[:fabrice] Fabrice Desré]

Comment on attachment 8519648 [details] [review]
Gaia Part. (v1) (pull request #25976)

I commented on github, but I defer to a settings peer anyway.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

I did not find anything from the document[1] regarding not placing english in the html file. Stas, could you help confirm that? 

[1]: https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/localization_code_best_practices

Comment 7

[Staś Małolepszy :stas]

Thanks for asking, Arthur!  Zibi posted about this to dev-gaia only a week ago, so it's a pretty new thing that we're trying to promote and that we ask you to follow:

  https://groups.google.com/forum/#!topic/mozilla.dev.gaia/XWPswH8nuuE

I updated the MDN page to mention this.  Let me know if you have any questions.

Comment 8

[Boris Chiou [:boris]]

(In reply to Staś Małolepszy :stas from comment #7)
> Thanks for asking, Arthur!  Zibi posted about this to dev-gaia only a week
> ago, so it's a pretty new thing that we're trying to promote and that we ask
> you to follow:
> 
>   https://groups.google.com/forum/#!topic/mozilla.dev.gaia/XWPswH8nuuE
> 
> I updated the MDN page to mention this.  Let me know if you have any
> questions.

Thanks for your clarification, I upload a new patch to remove the English translation. Thank you.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8519648 [details] [review]
Gaia Part. (v1) (pull request #25976)

Stas, thanks for the clarification.

r=me, thanks Boris!

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: d81ef65f1f30968b0fcc07a77fe69d8d24f4fba8

Comment 11

[Boris Chiou [:boris]]

(In reply to Arthur Chen [:arthurcc] from comment #10)
> master: d81ef65f1f30968b0fcc07a77fe69d8d24f4fba8

Hi Authur, this bug also has a Gecko patch. Should I checkin-need again for gecko side? Thanks.

Comment 12

[Boris Chiou [:boris]]

Checkin-needed for Attachment 8519642 [details] [diff]

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/dabdb445157d

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dabdb445157d

Comment 15

[Vincent Liu[:vliu]]

Hi Steven,

I need cherry-pick this patch into v2.1s branch for debugging purpose in the future. Thanks

Comment 16

[Boris Chiou [:boris]]

(In reply to Vincent Liu[:vliu] from comment #15)
> Hi Steven,
> 
> I need cherry-pick this patch into v2.1s branch for debugging purpose in the
> future. Thanks

If possible, please also cherry-pick Bug 1096139 which also makes the connection of layerscope easier.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Looks like this never made it to v2.1S. Do we still want it?

Comment 18

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

No, don't need this one on 2.1s