Closed Bug 1096139 Opened 6 years ago Closed 6 years ago

[LayerScope] Create websocket dynamically after we enable Layerscope

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: boris, Assigned: boris)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

After check-in Bug 1040651, we have create the websocket dynamically if anyone enables the preference, so we don't have to reboot the device. Make it simpler to enable the layerscope.
Depends on: 1040651
Assignee: nobody → boris.chiou
OS: Gonk (Firefox OS) → All
Hardware: ARM → All
Summary: [LayerScope] Create websocket dynamically if we enable the preference on the Gaia Settings. → [LayerScope] Create websocket dynamically after we enable Layerscope
Status: NEW → ASSIGNED
Blocks: LayerScope
No longer depends on: 1040651
Depends on: 1040651
Attachment #8525895 - Flags: review?(dglastonbury)
Attachment #8525895 - Flags: review?(dglastonbury)
We have to create the websocket if it doesn't exist after enabling
Layerscope. Therefore, we don't have to reboot the device anymore.

1. Remove the Init and DeInit in CreateCompositor and DestroyCompositor
   to prevent some unwanted deInits on the browser. (Our browser often
   calls DestroyCompositor)
2. Initize websocket only when we need it.

Fix Linux build errors.

Try build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe3cb7513787
Attachment #8525895 - Attachment is obsolete: true
Attachment #8525923 - Flags: review?(dglastonbury)
Comment on attachment 8525923 [details] [diff] [review]
Create websocket dynamically after we enable Layerscope (v2.1)

Review of attachment 8525923 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8525923 - Flags: review?(dglastonbury) → review+
(In reply to Dan Glastonbury :djg :kamidphish from comment #5)
> Comment on attachment 8525923 [details] [diff] [review]
> Create websocket dynamically after we enable Layerscope (v2.1)
> 
> Review of attachment 8525923 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> LGTM

Thanks, Dan.

Try server:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=18b8e8b1b787
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/138da1623668
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.