1096139 - [LayerScope] Create websocket dynamically after we enable Layerscope

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Boris Chiou [:boris]]

After check-in Bug 1040651, we have create the websocket dynamically if anyone enables the preference, so we don't have to reboot the device. Make it simpler to enable the layerscope.

Comment 1

[Boris Chiou [:boris]]

Attachment: [WIP] Create websocket dynamically after we enable Layerscope (v1)

We have to create the websocket if it doesn't exist after enabling
Layerscope. Therefore, we don't have to reboot the device anymore.

Comment 2

[Boris Chiou [:boris]]

Attachment: [WIP] Create websocket dynamically after we enable Layerscope (v1.1)

We have to create the websocket if it doesn't exist after enabling
Layerscope. Therefore, we don't have to reboot the device anymore.

1. Remove the Init and DeInit in CreateCompositor and DestroyCompositor
   to prevent some unwanted deInits on the browser. (Our browser often
   calls DestroyCompositor)
2. Initize websocket only when we need it.
3. Future work: Receive messages from our Viewer, so we can only send
   the data we wanted.

Comment 3

[Boris Chiou [:boris]]

Attachment: Create websocket dynamically after we enable Layerscope (v2)

We have to create the websocket if it doesn't exist after enabling
Layerscope. Therefore, we don't have to reboot the device anymore.

1. Remove the Init and DeInit in CreateCompositor and DestroyCompositor
   to prevent some unwanted deInits on the browser. (Our browser often
   calls DestroyCompositor)
2. Initize websocket only when we need it.

Try build:
https://tbpl.mozilla.org/?tree=Try&rev=f3ce40d75c3f

Comment 4

[Boris Chiou [:boris]]

Attachment: Create websocket dynamically after we enable Layerscope (v2.1)

We have to create the websocket if it doesn't exist after enabling
Layerscope. Therefore, we don't have to reboot the device anymore.

1. Remove the Init and DeInit in CreateCompositor and DestroyCompositor
   to prevent some unwanted deInits on the browser. (Our browser often
   calls DestroyCompositor)
2. Initize websocket only when we need it.

Fix Linux build errors.

Try build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe3cb7513787

Comment 5

[u480271]

Comment on attachment 8525923 [details] [diff] [review]
Create websocket dynamically after we enable Layerscope (v2.1)

Review of attachment 8525923 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 6

[Boris Chiou [:boris]]

(In reply to Dan Glastonbury :djg :kamidphish from comment #5)
> Comment on attachment 8525923 [details] [diff] [review]
> Create websocket dynamically after we enable Layerscope (v2.1)
> 
> Review of attachment 8525923 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> LGTM

Thanks, Dan.

Try server:
https://tbpl.mozilla.org/?tree=Try&rev=f8bf346135a0

Comment 7

[Boris Chiou [:boris]]

(In reply to Dan Glastonbury :djg :kamidphish from comment #5)
> Comment on attachment 8525923 [details] [diff] [review]
> Create websocket dynamically after we enable Layerscope (v2.1)
> 
> Review of attachment 8525923 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> LGTM

Thanks, Dan.

Try server:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=18b8e8b1b787

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/138da1623668

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/138da1623668