Closed
Bug 1096139
Opened 11 years ago
Closed 11 years ago
[LayerScope] Create websocket dynamically after we enable Layerscope
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: boris, Assigned: boris)
References
Details
Attachments
(1 file, 3 obsolete files)
7.06 KB,
patch
|
u480271
:
review+
|
Details | Diff | Splinter Review |
After check-in Bug 1040651, we have create the websocket dynamically if anyone enables the preference, so we don't have to reboot the device. Make it simpler to enable the layerscope.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → boris.chiou
Assignee | ||
Updated•11 years ago
|
OS: Gonk (Firefox OS) → All
Hardware: ARM → All
Summary: [LayerScope] Create websocket dynamically if we enable the preference on the Gaia Settings. → [LayerScope] Create websocket dynamically after we enable Layerscope
Comment hidden (obsolete) |
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•11 years ago
|
Blocks: LayerScope
No longer depends on: 1040651
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Assignee | ||
Updated•11 years ago
|
Attachment #8525895 -
Flags: review?(dglastonbury)
Assignee | ||
Updated•11 years ago
|
Attachment #8525895 -
Flags: review?(dglastonbury)
Assignee | ||
Comment 4•11 years ago
|
||
We have to create the websocket if it doesn't exist after enabling
Layerscope. Therefore, we don't have to reboot the device anymore.
1. Remove the Init and DeInit in CreateCompositor and DestroyCompositor
to prevent some unwanted deInits on the browser. (Our browser often
calls DestroyCompositor)
2. Initize websocket only when we need it.
Fix Linux build errors.
Try build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe3cb7513787
Attachment #8525895 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Attachment #8525923 -
Flags: review?(dglastonbury)
Comment on attachment 8525923 [details] [diff] [review]
Create websocket dynamically after we enable Layerscope (v2.1)
Review of attachment 8525923 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #8525923 -
Flags: review?(dglastonbury) → review+
Comment hidden (obsolete) |
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Dan Glastonbury :djg :kamidphish from comment #5)
> Comment on attachment 8525923 [details] [diff] [review]
> Create websocket dynamically after we enable Layerscope (v2.1)
>
> Review of attachment 8525923 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> LGTM
Thanks, Dan.
Try server:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=18b8e8b1b787
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 8•11 years ago
|
||
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•