Bump mozrunner and marionette-client for bug 1036926 and release to pypi

RESOLVED FIXED in mozilla34

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ahal, Assigned: ahal)

Tracking

unspecified
mozilla34
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

4 years ago
There have been some recent changes to mozrunner that are needed on pypi. One of those changes (bug 1036926) also requires a minor change to marionette-client. We should bump them both at the same time after bug 1036926 lands on m-c.

As Dave mentioned in the other bug, we may also need a gaiatest bump.

Comment 1

4 years ago
Created attachment 8458810 [details] [diff] [review]
Spy agent

Checking for activities..
Flags: needinfo?(ahalberstadt)
(Assignee)

Updated

4 years ago
Attachment #8458810 - Attachment is obsolete: true
Flags: needinfo?(ahalberstadt)
(Assignee)

Comment 2

4 years ago
Here's the list of changes since the last bump:

Bug 1036926 - Add ability to specify local_port in emulator.setup_port_forwarding(), r=wlach
Bug 886570 - Initial integration of structured logs in mochitest; r=ahal,Ms2ger
Bug 1034044 - Remove dependency on Marionette session from get_device_manager. r=jgriffin
Bug 1034044 - Remove dependency on Marionette session from get_device_manager. r=jgriffin
Bug 1036453 - "Typo in marionette docs". r=mdas
Bug 1037318 - Log a test_start and test_end message for skipped tests in marionette.;r=jgraham
Bug 1036365: Implement element.rect to marionette for getting element size and location; r=mdas
Bug 1036930 - Remove marionette/scripts/runemu.py, r=dburns
Backed out changeset 506038ddee2c (bug 1000040) for causing bug 1035172
Bug 997770 - Allow users to explicitly input the connection timeout. Also the  version of marionette_transport is updated from 0.2 to 0.3. r=mdas
(Assignee)

Comment 3

4 years ago
Created attachment 8459577 [details] [diff] [review]
Bump mozrunner and marionette-client

Those are just the changes for marionette-client, not mozrunner (we don't usually keep track of those in mozbase).

Dave, is there anything else I to do before landing this?
Attachment #8459577 - Flags: review?(dave.hunt)
Comment on attachment 8459577 [details] [diff] [review]
Bump mozrunner and marionette-client

Patch looks to be empty? A version bump and subsequent release of mozrunner will be picked up by the Gaia UI tests (marionette version is pinned), so there will only be an issue if gaiatest is not compatible with the latest mozrunner or the latest mozrunner requires the latest marionette client.
Attachment #8459577 - Flags: review?(dave.hunt) → review-
(Assignee)

Comment 5

4 years ago
Created attachment 8459645 [details] [diff] [review]
Bump mozrunner and marionette-client

Bah, sorry.. forgot to qref.

(In reply to Dave Hunt (:davehunt) from comment #4)
> Comment on attachment 8459577 [details] [diff] [review]
> Bump mozrunner and marionette-client
> 
> Patch looks to be empty? A version bump and subsequent release of mozrunner
> will be picked up by the Gaia UI tests (marionette version is pinned), so
> there will only be an issue if gaiatest is not compatible with the latest
> mozrunner or the latest mozrunner requires the latest marionette client.

If you try to use an older marionette-client with this mozrunner, then using the emulators will break. That's why I had to update the mozrunner dependency in marionette.

However since gaiatest isn't running on emulators, maybe this won't be a problem? Might be good to update it anyway just in case though.
Attachment #8459577 - Attachment is obsolete: true
Attachment #8459645 - Flags: review?(dave.hunt)
Comment on attachment 8459645 [details] [diff] [review]
Bump mozrunner and marionette-client

Review of attachment 8459645 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Running gaiatest against emulators is blocked, so I wouldn't expect any issues with this landing. I think following it up with a marionette-client dependency bump in gaiatest would be good practice though.
Attachment #8459645 - Flags: review?(dave.hunt) → review+
(Assignee)

Comment 8

4 years ago
Created attachment 8460426 [details] [review]
Bump gaiatest for new marionette-client

While I don't think gaiatest will break (since it doesn't use emulators), here's a patch to update it anyway.
Attachment #8460426 - Flags: review?(dave.hunt)
https://hg.mozilla.org/mozilla-central/rev/70bc8f7cde4e
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
(Assignee)

Comment 10

4 years ago
Re-opening to wait for gaiatest bump.

I also pushed the new mozrunner and marionette-client to pypi. I'll make a note in dev.tools about it.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8460426 [details] [review]
Bump gaiatest for new marionette-client

The Travis build failed because the new package wasn't available at the time. This looks good to me, but I also noticed bug 1039966 for updating the Marionette client in gaiatest.
Attachment #8460426 - Flags: review?(dave.hunt) → review+
(Assignee)

Comment 12

4 years ago
Oh, in that case I'll let :zac merge his pull request as he also updates the moztest dependency. I'll close mine.
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.