1040881 - Searching doesn't work on contacts with middle names

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

If you have a contact with the name "A B C" and type "A C" the search will fail to find it.  Importing contacts from Facebook tends to drag in a fair number middle names.

Comment 1

[Gregor Wagner [:gwagner]]

Does indexedDB support fulltext search?

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

No it doesn't.

Right now the search in contacts is based on DOM, since we don't have all the indexes to search for (org, etc.) and also to perform substring matching

The components added to the search string are:
givenName
familyName
tel
org
email

Comment 3

[Cristian Rodriguez (:crdlc)]

Hi Adrián, do you want to take a look at this bug?

Comment 4

[Jason Smith [:jsmith]]

QA Wanted for branch checks.

Comment 5

[Gregor Wagner [:gwagner]]

(In reply to Jason Smith [:jsmith] from comment #4)
> QA Wanted for branch checks.

This was never implemented.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Gregor Wagner [:gwagner] from comment #5)
> (In reply to Jason Smith [:jsmith] from comment #4)
> > QA Wanted for branch checks.
> 
> This was never implemented.

Yes, search in contacts, actually is happening via DOM reg exp matching (yes gods of programming punish us for doing that), since the API couldn't implement all the search combinations we wanted.

Comment 7

[Adrián de la Rosa]

Attachment: Pull request #22560

I fixed it by splitting the search terms and doing a regexp search for each of them.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8468338 [details]
Pull request #22560

I've tried in the phone and works perfectly.

Not granting the review since I left a couple of suggestions in the pull request hat will be pretty easy to tackle.

Thanks.

(BTW, I'll be on PTO till August 14th, if I'm not available you can forward the review to Jose)

Comment 9

[Jose Manuel Cantera]

Comment on attachment 8468338 [details]
Pull request #22560

thanks Adrian.

Comment 10

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/0366e78295a4c69ce69c7135a68de552d6b6d3e1