1040936 - (system-dialog) [Window Management] Improve interoperability between system dialogs and value selectors.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Currently there are several visibility issues between the system dialogs and the value selectors, in particular related to the z-index of the overlay dialog and the corresponding app's value-selector (such as the issue described in bug 1040290). The proper solution is to:

* have systemDialogManager get the mozChromeEvent, and stop propagation to avoid AppWindowManager getting it.
* dispatch the event to the active system dialog.
* do what we do in appWindow: install value-selector, call setVisible of system dialog (not implemented now)
* and we will need to the same thing again for other window managers if their window needs value selector.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Github pull request.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8468209 [details] [review]
Github pull request.

Yura, nice done.
I have some comments on github, lemme know if you have question to fix them. Thank you very much!

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8468209 [details] [review]
Github pull request.

All comments addressed. Marking for re-review.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8468209 [details] [review]
Github pull request.

Thank you very much!

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

https://github.com/mozilla-b2g/gaia/commit/dc5ab7839619e000e353872235f89425be7346ca

Comment 6

[howie [:howie]]

Mark as block because of bug 1042335

Comment 7

[Alissa（leave from Mozilla）]

This issue has been verified successfully on Flame 2.1,we also checked bug 1040290,there is no same issue found on other page,so I think it is fixed.
Flame 2.1 build:
Gaia-Rev        77c57eb8a985d5cbd34a597fb1b978ba6e205af6
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f05d0a2d2378
Build-ID        20150120001202
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150120.035022
FW-Date         Tue Jan 20 03:50:33 EST 2015
Bootloader      L1TC000118D0