1041339 - ServiceWorkers: Update implementation based on clarification of force-refresh.

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://github.com/slightlyoff/ServiceWorker/issues/377

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

As I see (if I'm not wrong) the implementation has not been updated yet. Nikhil, are you actively working on this bug? If not and you think this one would be another good-first-bug would you mind me to take it and work on it? Thanks!

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #1)
> As I see (if I'm not wrong) the implementation has not been updated yet.
> Nikhil, are you actively working on this bug? If not and you think this one
> would be another good-first-bug would you mind me to take it and work on it?
> Thanks!

If https://mxr.mozilla.org/mozilla-central/source/dom/base/nsDocument.cpp#4794 is the way to detect the navigation triggering request was initiated with a shift+reload I guess there is nothing to do here but remove the message you left. Please, let me know Nikhil.

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #2)
> (In reply to José Antonio Olivera Ortega [:jaoo] from comment #1)
> > As I see (if I'm not wrong) the implementation has not been updated yet.
> > Nikhil, are you actively working on this bug? If not and you think this one
> > would be another good-first-bug would you mind me to take it and work on it?
> > Thanks!
> 
> If
> https://mxr.mozilla.org/mozilla-central/source/dom/base/nsDocument.cpp#4794
> is the way to detect the navigation triggering request was initiated with a
> shift+reload I guess there is nothing to do here but remove the message you
> left. Please, let me know Nikhil.

You are correct.

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Attachment: v1

Here is the patch in case you want to land it. Did a push to try, here is the link:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5faf70fee6e

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5cd15b96335f

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5cd15b96335f