1041463 - Include a shared CSS file with @import rule

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

To properly address bug 1023702, we would need to introduce a shared CSS file that assign a CSS value. Such file would be @import'ed by other CSS file instead of being referenced by <link>, so the build script would need to correctly parse CSS, find @import, and put the file in the package.

Comment 1

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I'm becoming a volunteer so don't have enough bandwidth to help on it, cancel needinfo.

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

also nedinfo? Ricky for further work.

Comment 3

[Ricky Chien [:rickychien] (inactive)]

OK! I can pick up this bug.

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Attachment: Gaia PR

Comment 5

[Ricky Chien [:rickychien] (inactive)]

I think George is the best person for reviewing webapp-shared.js.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8495835 [details] [review]
Gaia PR

I've addressed some points in github. Please try to add build integration test to guarantee the import styles have been copied into profile.

Please set r? to me once you finish! Thanks.

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8495835 [details] [review]
Gaia PR

PR updated!

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8495835 [details] [review]
Gaia PR

well done, r=gduan

Comment 9

[Ricky Chien [:rickychien] (inactive)]

Thank you George. Pull request has merged.

https://github.com/mozilla-b2g/gaia/commit/e96f8dd7e881693e80b93371d76d2178db6c15c5