1041475 - TEST-UNEXPECTED-FAIL | mozmill/content-tabs/test-install-xpi.js | test-install-xpi.js::test_install_corrupt_xpi + test-install-xpi.js::test_install_xpi_offer + test-install-xpi.js::test_xpinstall_disabled + test-install-xpi.js::test_xpinstall_actually_i

Assignee

Description

•

12 years ago

Step Pass: {"function": "controller.click()"} ************************************************************ * Call to xpconnect wrapped JSObject produced this error: * [Exception... "[JavaScript Error: "win is undefined" {file: "chrome://messenger/content/specialTabs.js" line: 1235}]'[JavaScript Error: "win is undefined" {file: "chrome://messenger/content/specialTabs.js" line: 1235}]' when calling method: [nsIObserver::observe]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: resource://gre/components/amWebInstallListener.js :: extWebInstallListener_onWebInstallBlocked :: line 302" data: yes] ************************************************************ Test Failure: Timeout waiting for alert TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\content-tabs\test-install-xpi.js | test-install-xpi.js::test_install_corrupt_xpi TEST-START | C:\slave\test\build\mozmill\content-tabs\test-install-xpi.js | test_install_xpi_offer Step Pass: {"function": "controller.click()"} ************************************************************ * Call to xpconnect wrapped JSObject produced this error: * [Exception... "[JavaScript Error: "win is undefined" {file: "chrome://messenger/content/specialTabs.js" line: 1235}]'[JavaScript Error: "win is undefined" {file: "chrome://messenger/content/specialTabs.js" line: 1235}]' when calling method: [nsIObserver::observe]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: resource://gre/components/amWebInstallListener.js :: extWebInstallListener_onWebInstallBlocked :: line 302" data: yes] ************************************************************ Test Failure: Timeout waiting for alert TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\content-tabs\test-install-xpi.js | test-install-xpi.js::test_install_xpi_offer TEST-START | C:\slave\test\build\mozmill\content-tabs\test-install-xpi.js | test_xpinstall_disabled Step Pass: {"function": "controller.click()"} ************************************************************ * Call to xpconnect wrapped JSObject produced this error: * [Exception... "[JavaScript Error: "win is undefined" {file: "chrome://messenger/content/specialTabs.js" line: 1235}]'[JavaScript Error: "win is undefined" {file: "chrome://messenger/content/specialTabs.js" line: 1235}]' when calling method: [nsIObserver::observe]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: resource://gre/components/amWebInstallListener.js :: extWebInstallListener_onWebInstallDisabled :: line 284" data: yes] ************************************************************ Test Failure: Timeout waiting for alert TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\content-tabs\test-install-xpi.js | test-install-xpi.js::test_xpinstall_disabled TEST-START | C:\slave\test\build\mozmill\content-tabs\test-install-xpi.js | test_xpinstall_actually_install Step Pass: {"function": "controller.click()"} ************************************************************ * Call to xpconnect wrapped JSObject produced this error: * [Exception... "[JavaScript Error: "win is undefined" {file: "chrome://messenger/content/specialTabs.js" line: 1235}]'[JavaScript Error: "win is undefined" {file: "chrome://messenger/content/specialTabs.js" line: 1235}]' when calling method: [nsIObserver::observe]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: resource://gre/components/amWebInstallListener.js :: extWebInstallListener_onWebInstallDisabled :: line 284" data: yes] ************************************************************ SUMMARY-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\content-tabs\test-install-xpi.js | test-install-xpi.js::test_install_corrupt_xpi EXCEPTION: Timeout waiting for alert at: utils.js line 447 TimeoutError utils.js:447 13 waitFor utils.js:485 1 MozMillController.prototype.waitFor controller.js:685 3 AlertWatcher.waitForAlert test-install-xpi.js:37 1 click_install_link_and_wait_for_alert test-install-xpi.js:83 3 test_install_corrupt_xpi test-install-xpi.js:102 3 Runner.prototype.wrapper frame.js:585 9 Runner.prototype._runTestModule frame.js:655 9 Runner.prototype.runTestModule frame.js:701 3 Runner.prototype.runTestDirectory frame.js:525 7 runTestDirectory frame.js:707 3 Bridge.prototype._execFunction server.js:179 10 Bridge.prototype.execFunction server.js:183 16 Session.prototype.receive server.js:283 3 AsyncRead.prototype.onDataAvailable server.js:88 3 SUMMARY-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\content-tabs\test-install-xpi.js | test-install-xpi.js::test_install_xpi_offer EXCEPTION: Timeout waiting for alert at: utils.js line 447 TimeoutError utils.js:447 13 waitFor utils.js:485 1 MozMillController.prototype.waitFor controller.js:685 3 AlertWatcher.waitForAlert test-install-xpi.js:37 1 click_install_link_and_wait_for_alert test-install-xpi.js:83 3 test_install_xpi_offer test-install-xpi.js:120 3 Runner.prototype.wrapper frame.js:585 9 Runner.prototype._runTestModule frame.js:655 9 Runner.prototype.runTestModule frame.js:701 3 Runner.prototype.runTestDirectory frame.js:525 7 runTestDirectory frame.js:707 3 Bridge.prototype._execFunction server.js:179 10 Bridge.prototype.execFunction server.js:183 16 Session.prototype.receive server.js:283 3 AsyncRead.prototype.onDataAvailable server.js:88 3 SUMMARY-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\content-tabs\test-install-xpi.js | test-install-xpi.js::test_xpinstall_disabled EXCEPTION: Timeout waiting for alert at: utils.js line 447 TimeoutError utils.js:447 13 waitFor utils.js:485 1 MozMillController.prototype.waitFor controller.js:685 3 AlertWatcher.waitForAlert test-install-xpi.js:37 1 click_install_link_and_wait_for_alert test-install-xpi.js:83 3 test_xpinstall_disabled test-install-xpi.js:137 3 Runner.prototype.wrapper frame.js:585 9 Runner.prototype._runTestModule frame.js:655 9 Runner.prototype.runTestModule frame.js:701 3 Runner.prototype.runTestDirectory frame.js:525 7 runTestDirectory frame.js:707 3 Bridge.prototype._execFunction server.js:179 10 Bridge.prototype.execFunction server.js:183 16 Session.prototype.receive server.js:283 3 AsyncRead.prototype.onDataAvailable server.js:88 3 SUMMARY-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\content-tabs\test-install-xpi.js | test-install-xpi.js::test_xpinstall_actually_install EXCEPTION: Timeout waiting for alert at: utils.js line 447 TimeoutError utils.js:447 13 waitFor utils.js:485 1 MozMillController.prototype.waitFor controller.js:685 3 AlertWatcher.waitForAlert test-install-xpi.js:37 1 click_install_link_and_wait_for_alert test-install-xpi.js:83 3 test_xpinstall_actually_install test-install-xpi.js:144 3 Runner.prototype.wrapper frame.js:585 9 Runner.prototype._runTestModule frame.js:655 9 Runner.prototype.runTestModule frame.js:701 3 Runner.prototype.runTestDirectory frame.js:525 7 runTestDirectory frame.js:707 3 Bridge.prototype._execFunction server.js:179 10 Bridge.prototype.execFunction server.js:183 16 Session.prototype.receive server.js:283 3 AsyncRead.prototype.onDataAvailable server.js:88 3 SUMMARY-PASS | test-install-xpi.js::teardownModule First(?) seen in https://tbpl.mozilla.org/?tree=Thunderbird-Trunk&rev=dd587f8d4d97 - fallout from bug 952201 - http://hg.mozilla.org/mozilla-central/rev/53f37bbfd7ab I guess I can look into this, if nobody's on it already...

Comment hidden (Legacy TBPL/Treeherder Robot)

Magnus Melin [:mkmelin]

Assignee

Comment 6

•

12 years ago

Attached patch bug1041475_xpi_test_fail.patch — Details — Splinter Review

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=ccc38975800e looks good This fixes the test failure, and I think making xpi install in specialTabs work with e10s is out of scope for this bug.

Attachment #8460155 - Flags: review?(mconley)

Magnus Melin [:mkmelin]

Assignee

Updated

•

12 years ago

Status: NEW → ASSIGNED

Comment hidden (Legacy TBPL/Treeherder Robot)

RyanVM https://tbpl.mozilla.org/php/getParsedLog.php?id=44266445&tree=Thunderbird-Trunk TB Windows 7 32-bit comm-central opt test mozmill on 2014-07-21 04:22:35 revision: fa7f8f8f6c7e slave: t-w732-ix-106 TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\content-tabs\test-install-xpi.js | test-install-xpi.js::test_install_corrupt_xpi TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\content-tabs\test-install-xpi.js | test-install-xpi.js::test_install_xpi_offer TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\content-tabs\test-install-xpi.js | test-install-xpi.js::test_xpinstall_disabled TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\content-tabs\test-install-xpi.js | test-install-xpi.js::test_xpinstall_actually_install TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\folder-widget\test-message-filters.js | test-message-filters.js::test_customize_toolbar_doesnt_double_get_mail_menu TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\message-header\test-message-header.js | test-message-header.js::test_address_book_switch_disabled_on_contact_in_mailing_list TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\tabmail\test-tabmail-customize.js | test-tabmail-customize.js::test_redirects_toolbarbutton_drops TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\tabmail\test-tabmail-customize.js | test-tabmail-customize.js::teardownModule TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run TypeError: Components.classes[cid] is undefined TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\testBasicFunctionality.js | testBasicFunctionality.js::teardownTest TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\testBasicFunctionality.js | testBasicFunctionality.js::testSmokeTest TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\testLocalICS.js | testLocalICS.js::<TOP_LEVEL> TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\testTodayPane.js | testTodayPane.js::<TOP_LEVEL> TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run Only displaying first 20 of 22 failures - .

Comment hidden (Legacy TBPL/Treeherder Robot)

RyanVM https://tbpl.mozilla.org/php/getParsedLog.php?id=44265368&tree=Thunderbird-Trunk Ubuntu VM 12.04 x64 comm-central opt test mozmill on 2014-07-21 04:06:40 revision: fa7f8f8f6c7e slave: tst-linux64-spot-1006 TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/composition/test-attachment-reminder.js | test-attachment-reminder.js::test_attachment_reminder_appears_properly TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/content-tabs/test-install-xpi.js | test-install-xpi.js::test_install_corrupt_xpi TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/content-tabs/test-install-xpi.js | test-install-xpi.js::test_install_xpi_offer TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/content-tabs/test-install-xpi.js | test-install-xpi.js::test_xpinstall_disabled TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/content-tabs/test-install-xpi.js | test-install-xpi.js::test_xpinstall_actually_install TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/folder-widget/test-message-filters.js | test-message-filters.js::test_customize_toolbar_doesnt_double_get_mail_menu TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/tabmail/test-tabmail-customize.js | test-tabmail-customize.js::test_redirects_toolbarbutton_drops TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/tabmail/test-tabmail-customize.js | test-tabmail-customize.js::teardownModule TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run TypeError: Components.classes[cid] is undefined TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/testBasicFunctionality.js | testBasicFunctionality.js::teardownTest TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/testBasicFunctionality.js | testBasicFunctionality.js::testSmokeTest TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/testLocalICS.js | testLocalICS.js::<TOP_LEVEL> TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/testTodayPane.js | testTodayPane.js::<TOP_LEVEL> TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run Only displaying first 20 of 22 failures - .

Comment hidden (Legacy TBPL/Treeherder Robot)

Mike Conley (:mconley) (:⚙️)

Comment 14

•

12 years ago

Comment on attachment 8460155 [details] [diff] [review] bug1041475_xpi_test_fail.patch Thanks Magnus!

Attachment #8460155 - Flags: review?(mconley) → review+

Comment hidden (Legacy TBPL/Treeherder Robot)

Magnus Melin [:mkmelin]

Assignee

Comment 20

•

12 years ago

https://hg.mozilla.org/comm-central/rev/42281e0027ee

Status: ASSIGNED → RESOLVED

Closed: 12 years ago

Resolution: --- → FIXED

Target Milestone: --- → Thunderbird 34.0

Mike Conley (:mconley) (:⚙️)

Comment 21

•

12 years ago

Does this need uplift to c-a?

Flags: needinfo?(mkmelin+mozilla)

Magnus Melin [:mkmelin]

Assignee

Comment 22

•

12 years ago

Comment on attachment 8460155 [details] [diff] [review] bug1041475_xpi_test_fail.patch [Approval Request Comment] Regression caused by (bug #): bug 952201 User impact if declined: can't install xpis in specialTabs Testing completed (on c-c, etc.): tests pass on trunk Risk to taking this patch (and alternatives if risky): very low

Attachment #8460155 - Flags: approval-comm-aurora?

Flags: needinfo?(mkmelin+mozilla)

Mark Banner (:standard8)

Updated

•

12 years ago

Attachment #8460155 - Flags: approval-comm-aurora? → approval-comm-aurora+

Mark Banner (:standard8)

Comment 23

•

12 years ago

https://hg.mozilla.org/releases/comm-aurora/rev/dd76794f296a

status-thunderbird33: --- → fixed

Mark Banner (:standard8)

Updated

•

11 years ago

status-thunderbird34: --- → fixed