Closed Bug 1041641 Opened 6 years ago Closed 6 years ago

Search fragment grabs clicks when activity first launches

Categories

(Firefox for Android Graveyard :: Search Activity, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 34

People

(Reporter: eedens, Assigned: Margaret)

References

Details

Attachments

(3 files)

When the search activity first launches, the card view isn't receiving clicks; after doing a search, the cards become clickable.

It looks like the ListView from the search fragment is clickable when the activity first launches; after the search, however, it is no longer clickable.
Attached image layout-first-launch.png
Here's the UI hierarchy when the activity first launches
Attached image layout-after-search.png
Here's the hierarchy after cycling through transitionToRunning to transitionToWaiting
Took a peek at the View#setOnClickListener implementation to see what's going on here.

I was also thinking we could lazily set this listener in transitionToRunning, but we would need to add some check to see if we've already set the click listener, so I'm not sure that it's worth it.
Attachment #8460535 - Flags: review?(eedens)
Comment on attachment 8460535 [details] [diff] [review]
Disable SearchFragment mainView click listener when creating view

Review of attachment 8460535 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8460535 - Flags: review?(eedens) → review+
https://hg.mozilla.org/mozilla-central/rev/d6d71882318d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.