1041641 - Search fragment grabs clicks when activity first launches

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Eric Edens [:eedens]]

When the search activity first launches, the card view isn't receiving clicks; after doing a search, the cards become clickable.

It looks like the ListView from the search fragment is clickable when the activity first launches; after the search, however, it is no longer clickable.

Comment 1

[Eric Edens [:eedens]]

Attachment: layout-first-launch.png

Here's the UI hierarchy when the activity first launches

Comment 2

[Eric Edens [:eedens]]

Attachment: layout-after-search.png

Here's the hierarchy after cycling through transitionToRunning to transitionToWaiting

Comment 3

[:Margaret Leibovic]

Attachment: Disable SearchFragment mainView click listener when creating view

Took a peek at the View#setOnClickListener implementation to see what's going on here.

I was also thinking we could lazily set this listener in transitionToRunning, but we would need to add some check to see if we've already set the click listener, so I'm not sure that it's worth it.

Comment 4

[Eric Edens [:eedens]]

Comment on attachment 8460535 [details] [diff] [review]
Disable SearchFragment mainView click listener when creating view

Review of attachment 8460535 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/d6d71882318d

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d6d71882318d

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d6d71882318d