1041679 - implement the shadow behind the global webrtc sharing indicator

Status: RESOLVED WONTFIX

(Firefox :: Site Permissions, defect)

Description

[Florian Quèze [:florian]]

I don't think we are currently displaying the shadow that was part of the UX mockups.

I wouldn't necessarily be against wontfixing this bug if we decide what we currently have is good enough; but the reason why it's currently not implemented was purely lack of time when finishing bug 1037408 that had to land before the Firefox 33 string freeze.

Comment 1

[Dão Gottwald [:dao]]

Where's the mockup for this?

Comment 2

[Florian Quèze [:florian]]

Philipp, I remember we discussed a shadow behind the global indicator and Gijs was reluctant to implement it immediately, but I can't find any mockup showing how the shadow is expected to look. Do you remember if there was one?

Comment 3

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: Mockup with shadow

Here's the mockup. The shadow is the equivalent of
> box-shadow: 0 3px 13px rgba(0,0,0,0.35);

Comment 4

[Roman Skalish]

Florian, I am also looking on this bug and currently now trying to add shadow behind the sharing indicator, but with no success.
I've tried it to do in webrtc\indicator.css by adding next code:
#webrtcIndicator {
  -webkit-box-shadow: 0 3px 13px rgba(0,0,0,0.35);
  -moz-box-shadow:    0 3px 13px rgba(0,0,0,0.35);
  box-shadow:         0 3px 13px rgba(0,0,0,0.35);
}
and also inside content\wertcindicator.xul by changing style of window.
So, should it be implemented some where else or by other way, or if you prefer to fix this bug, I can live it :) ?

Comment 5

[Florian Quèze [:florian]]

We just discussed this a little bit in the #fx-team channel: http://logs.glob.uno/?c=mozilla%23fx-team#c156199

I don't have a good solution to offer, unfortunately. Someone suggested tweaking the list of window features at http://mxr.mozilla.org/mozilla-central/source/browser/modules/webrtcUI.jsm#422
This may help, but I'm not sure.

Comment 6

[Roman Skalish]

Just small note. I've tried solution which provided Gijs "one option would be to add a container inside the window, make the window fully transparent, and add shadow to the container", but with no luck. It displays some shadow, only on the right side of control and also we need to re-draw the border of control, because even if we can draw shadow it will be inside border.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Dao, any status updates here?

Comment 8

[Dão Gottwald [:dao]]

I couldn't figure out how to do this. It might be easier if the indicator was a panel rather than a window, but that might have other drawbacks like the fact that panels can't exist independently but are technically tied to a window. We probably don't want to go down that road just for a drop shadow.

Comment 9

[:Gijs (he/him)]

Neil, is there some way to get the same panel-y shadows on a window, that you know of? :-)

Comment 10

[Neil Deakin]

Panel dropshadows are drawn manually using box-shadow. If you can't get the transparency to work, it's possible that it isn't supported with windows opened with the popup flag, or there is some specific combination of window style flags used here that doesn't handle transparency.

Comment 11

[alex_mayorga]

Attachment: new-gUM-indicator.png

¡Hola!

The new gUM indicator on 79 is very plain looking so perhaps shadows won't be needed anymore.

I looked a bit and couldn't find the designs so I can't definitively tell.

Hope this is a helpful comment.

¡Gracias!
Alex

Comment 12

[:Gijs (he/him)]

I'll close this out; if we want shadows around the other indicator I'm sure the new indicator bug tree will have something on file about that.