1041743 - Add ability to turn on/off Search Suggestions in preferences

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect)

Description

[Sevaan Franks [:sevaan]]

Attachment: Mockup showing placement in in-content preferences

A checkbox needs to be added to the "Content" section of Firefox preferences which allows users to turn on/off Search Suggestions in the Awesome Bar.

String: ☑ Show search suggestions in Awesome Bar.

Comment 1

[:Gijs (out for now; he/him)]

Shouldn't this appear under Privacy (or, dare I say it - General)? Content is about what gets displayed inside the tab / "viewport", and this is about a browser feature.

Comment 2

[Sevaan Franks [:sevaan]]

(In reply to :Gijs Kruitbosch from comment #1)
> Shouldn't this appear under Privacy (or, dare I say it - General)? Content
> is about what gets displayed inside the tab / "viewport", and this is about
> a browser feature.

Yes, I suppose you are right. I didn't consider the Privacy tab, but now I see that other Location Bar preferences are under it. Let's move it to the Privacy tab as per your suggestion. Thanks!

Comment 3

[Drew Willcoxon :adw]

There's already a dropdown labeled "When using the location bar, suggest:".  That should include search suggestions, no?  It doesn't really make sense to have both that dropdown and then a separate checkbox for search suggestions.  The two should be consolidated somehow.

Now that we have three choices -- history, bookmarks, and search suggestions -- would three checkboxes be appropriate?

Comment 4

[Marco Bonardo [:mak]]

bug 530209 :)
The problem is that autocomplete prefs suck. you can workaround something here sure, but the problem is larger.

Comment 5

[Alex Bardas :alexbardas]

Attachment: WIP incontent privacy locationbar screenshot

I already have some work in progress here that would hopefully also solve bug 530209. I can easily provide patches for each bug (the one from this should be rebased on top of the one from bug 530209).

I'd like to have an updated mockup to adjust my WIP.

Comment 6

[Sevaan Franks [:sevaan]]

Attachment: Location Bar pref checkboxes instead of drop-down

(In reply to Drew Willcoxon :adw from comment #3)
 
> Now that we have three choices -- history, bookmarks, and search suggestions
> -- would three checkboxes be appropriate?

Yes, this is an elegant solution, rather than adding an extra option into the dropdown. Good thinking!

Comment 7

[Andrei Vaida [:avaida]]

Assigning this to myself since I'm already working on several other related bugs.

Comment 8

[eyal gruss]

WFM in 38

Comment 9

[Marco Bonardo [:mak]]

we implemented the option in privacy / Location Bar, further work will happen elsewhere once designed (shorlander on that).