1041841 - [B2G][Settings][Download] Multiple strings while interacting with the downloads settings are missing.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Dean R. Gomez (DeanG)]

Attachment: Download_Strings.png

Description:
1. The "Download stopped" screen is missing strings.
2. The "Unsupported file" screen is missing strings.
3. The "Unable to open file type" screen is missing strings.
4. The "Delete" screen is missing strings.
5. The "Download Failed" screen is missing strings.
6. The "Delete 'x' files" screen is missing strings.
7. The "Stop download" screen is missing strings.

Prerequisites: Begin to download a file and cancel it.

Repro Steps (Example for #1 in description):
1) Update a Flame to 20140721000201
2) Go to a website in browser and download a file.
3) As the file is downloading, cancel it.
4) Go to Settings > Downloads.
5) Press the circular arrow button to the right of the file that was canceled downloading.
6) Observe the "Download stopped" screen.

Actual:
The "Download stopped" screen is missing all strings above the "Cancel" and "Try Again".
Expected:
All strings on the "Download stopped" screen will display correctly.

2.0 Environmental Variables:
Device: Flame 2.0 (273MB)
Build ID: 20140721000201
Gaia: 8cb1a949f2e9650bb2c5598e78a6f24a58bbaf97
Gecko: 4bd4b0ae7bbe
Version: 32.0a2 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Repro frequency: 8/8 - 100%
See attached: Logcat_Download_Strings.txt, Download_Strings.png

Comment 1

[Dean R. Gomez (DeanG)]

Attachment: Logcat_Download_Strings.txt

Attaching logcat.

Comment 2

[Dean R. Gomez (DeanG)]

This issue DOES occur on Flame 2.0 (512MB).


Flame 2.0 (512MB)

2.0 Environmental Variables:
Device: Flame 2.0 (273MB)
Build ID: 20140721000201
Gaia: 8cb1a949f2e9650bb2c5598e78a6f24a58bbaf97
Gecko: 4bd4b0ae7bbe
Version: 32.0a2 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Result: Multiple strings will be missing from their respective screens.

-----------------------------------------------------------------------------------

This issue DOES NOT occur on  Flame 2.1 (273MB), Flame 1.4 (273MB), and Buri 1.4.


Flame 2.1 (273MB)

2.1 Environmental Variables:
Device: Flame Master
BuildID: 20140721062116
Gaia: Unknown
Gecko: 0dc711216018
Version: 33.0a1
Firmware Version: v122
2.1 - Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0


Flame 1.4 (273MB)

1.4 Environmental Variables:
Device: Flame 1.4
Build ID: 20140721000201
Gaia: 621d152f89347c79619aa909ad62cc2ac9d3ab5b
Gecko: 83b7be7fb33f
Version: 30.0 (1.4)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0


Buri 1.4

1.4 Environmental Variables:
Device: Buri 1.4
Build ID: 20140721000201
Gaia: 621d152f89347c79619aa909ad62cc2ac9d3ab5b
Gecko: 83b7be7fb33f
Version: 30.0 (1.4)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0


Result: The multiple strings for their respective screens appear.

Comment 3

[Dean R. Gomez (DeanG)]

NOTE: Requesting QAWanted to grab remaining variables.

Comment 4

[Dean R. Gomez (DeanG)]

Providing missing variables.

This issue DOES occur on Buri 2.0.

2.0 Environmental Variables:
Device: Buri 2.0
Build ID: 20140721003002
Gaia: 8cb1a949f2e9650bb2c5598e78a6f24a58bbaf97
Gecko: 4bd4b0ae7bbe
Version: 32.0a2 (2.0) MOZ
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Result: Multiple strings will be missing from their respective screens.

----------------------------------------------------------------------

This issue DOES NOT occur on Buri 2.1, Open_C 1.4, and Open_C 2.1.


Buri 2.1

2.1 Environmental Variables:
Device: Buri Master
BuildID: 20140721062116
Gaia: Unknown
Gecko: 0dc711216018
Version:  33.0a1
Firmware Version: v1.2-device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0


Open_C 1.4

1.4 Environmental Variables:
Device: Open_C 1.4
Build ID: 20140721000201
Gaia: 621d152f89347c79619aa909ad62cc2ac9d3ab5b
Gecko: 83b7be7fb33f
Version: 30.0 (1.4)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0


Open_C 2.1

2.1 Environmental Variables:
Device: Open_C Master
Build ID: 20140721062116
Gaia: Unknown
Gecko: 0dc711216018
Version: 33.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0 


Result: The multiple strings for their respective screens appear.

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

Please update the 2.1 tracking flag appropriately.

Comment 6

[Dean R. Gomez (DeanG)]

Updated the 2.1 tracking flag to 'unaffected'.

Comment 7

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]: This is a regression from 1.4 and there are many missing strings so nominating this 2.0?

Comment 8

[Preeti Raghunath(:Preeti)]

Are we taking new strings here? If no, we'll block on it for 2.0

Comment 9

[Jason Smith [:jsmith]]

Gregor - Can you find an assignee for this bug?

Comment 10

[Gregor Wagner [:gwagner]]

Aus, any idea whats going on?

Comment 11

[Aus Lacroix [:aus]]

Feels to me like something wasn't uplifted that should've been? Do we have a regression window yet? I'm going to look at the last commits I did related to this in the meantime.

Comment 12

[Aus Lacroix [:aus]]

Offending commit: https://github.com/mozilla-b2g/gaia/commit/1cd5a8546959df287ec56fd619f68877148cd1f9

v2.0 l10n API does *not* use the MutationObserver like it does in 2.1. It's therefor necessary to trigger translation of the fragment manually.

Pull request incoming.

Comment 13

[Aus Lacroix [:aus]]

Attachment: Pull Request - Manually translate fragment as l10n api does not use mutation observer in 2.0.

Comment 14

[Duane Dixon [:ddixon]]

Aurora Regression Window

Last Working

Environmental Variables:
Device: Flame 2.0
Build ID: 20140709115133
Gaia: 29b78711df232870bfb57f6b335f94063b83c36b
Gecko: 1477ae71af9c
Version: 32.0a2 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

First Broken

Environmental Variables:
Device: Flame 2.0
Build ID: 20140709133231
Gaia: 1cd5a8546959df287ec56fd619f68877148cd1f9
Gecko: 6a7a6089f214
Version: 32.0a2 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Last Working Gaia and First Broken Gecko
Issue DOES NOT occur here. 
Gaia: 29b78711df232870bfb57f6b335f94063b83c36b
Gecko: 6a7a6089f214

Last Working Gecko and First Broken Gaia
Issue DOES occur here. 
Gaia: 1cd5a8546959df287ec56fd619f68877148cd1f9
Gecko: 1477ae71af9c

Gaia Pushlog: 
https://github.com/mozilla-b2g/gaia/compare/29b78711df232870bfb57f6b335f94063b83c36b...1cd5a8546959df287ec56fd619f68877148cd1f9

Possible Cause: 
Bug 1035367 - Update download_ui.js so that it uses data-l10n-id and dat...

Comment 15

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8462021 [details] [review]
Pull Request - Manually translate fragment as l10n api does not use mutation observer in 2.0.

LGTM, thanks a lot

Comment 16

[Aus Lacroix [:aus]]

Commit (v2.0 only!): https://github.com/mozilla-b2g/gaia/commit/0a864988f5dce7f9f3dea9609e8ef054679c30ff

Fixed!