Closed
Bug 1041866
Opened 11 years ago
Closed 11 years ago
Enable arithmetic optimization in proguard.cfg
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
All
Android
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla34
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
(Keywords: perf)
Attachments
(1 file)
|
1.03 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
The Android build tools generate a stock proguard.cfg which disables arithmetic operations:
# Switch off some optimizations that trip older versions of the Dalvik VM.
-optimizations !code/simplification/arithmetic
This was fixed three years ago:
https://groups.google.com/d/msg/android-developers/v_o0AQ7o8gI/l3DUuf-mJ5oJ
and doesn't affect any release we now target.
We should enable this optimization.
|
Assignee | |
Comment 1•11 years ago
|
||
Untested.
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Makes sense to me.
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8459975 [details] [diff] [review]
Enable arithmetic optimization in proguard.cfg. v1
This is more a sanity check than anything. See earlier bug comments.
Attachment #8459975 -
Flags: review?(mark.finkle)
|
||
Updated•11 years ago
|
Attachment #8459975 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
||
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
|
||
Updated•6 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 34 → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•