Closed Bug 1041901 Opened 7 years ago Closed 7 years ago

[Contacts] Customize Status Bar Color

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.1 verified)

RESOLVED FIXED
2.1 S3 (29aug)
Tracking Status
b2g-v2.1 --- verified

People

(Reporter: mikehenrty, Assigned: mikehenrty)

References

Details

(Whiteboard: [systemsfe])

Attachments

(3 files, 2 obsolete files)

For 2.1, each app will have a customized status bar color. Work to support this was completed in bug 1013913 and bug 1033364. Now we must update each of the apps with the appropriate meta tags as specified in the visual spec:

https://bug1041625.bugzilla.mozilla.org/attachment.cgi?id=8460033
Moving to next sprint ;)
Target Milestone: 2.1 S1 (1aug) → 2.1 S2 (15aug)
Attached image [screenshot] Contacts with theme color (obsolete) —
Attachment #8471220 - Flags: ui-review?(epang)
Comment on attachment 8471220 [details]
[screenshot] Contacts with theme color

Thanks Michael, but the status bar background is looking a little dark.  Is the value #00a4a4 ?  R- for now, let me know when it's ready to be checked again :)
Attachment #8471220 - Flags: ui-review?(epang) → ui-review-
(In reply to Eric Pang [:epang] from comment #4)
> Comment on attachment 8471220 [details]
> [screenshot] Contacts with theme color
> 
> Thanks Michael, but the status bar background is looking a little dark.  Is
> the value #00a4a4 ?  R- for now, let me know when it's ready to be checked
> again :)

Yes, the value is indeed #00a4a4 in the screenshot. You can verify in the commit here [1]. Shall we try a lighter value?

1.)https://github.com/mikehenrty/gaia/commit/9a3f5835578aac0b5f1fb3da204eab2c4b26a6aa#diff-746af7a66de23bbffcc53beda42c57daR6
Flags: needinfo?(epang)
Attached image contacts.jpg (obsolete) —
Same thing seems to be happening here as in email.  When I sample the colour i get
#009393.  Almost like there's a black overlay. Is there anything in the code that could be causing this?
Flags: needinfo?(epang)
Hei Mike,

is the final color the correct one? The change looks ... let me think ... perfect to me ;)

So if it's the final one, I'll be happy to r+ here.

Thanks a lot!
Flags: needinfo?(mhenretty)
Target Milestone: 2.1 S2 (15aug) → 2.1 S3 (29aug)
Comment on attachment 8471216 [details] [review]
[Gaia PR] fix theme color for contacts

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #7)
> Hei Mike,
> 
> is the final color the correct one? The change looks ... let me think ...
> perfect to me ;)
> 
> So if it's the final one, I'll be happy to r+ here.
> 
> Thanks a lot!

We are still figuring out the color issue. You can see that disucssion here: https://bugzilla.mozilla.org/show_bug.cgi?id=1041896#c8. I'll reflag you when we figure it out.
Attachment #8471216 - Flags: review?(francisco)
Flags: needinfo?(mhenretty)
Eric, how does this look?
Attachment #8471220 - Attachment is obsolete: true
Attachment #8472257 - Attachment is obsolete: true
Attachment #8476171 - Flags: ui-review?(epang)
Comment on attachment 8476171 [details]
[screenshot] Contacts theme fixed

Looks good, thanks!
Attachment #8476171 - Flags: ui-review?(epang) → ui-review+
Comment on attachment 8471216 [details] [review]
[Gaia PR] fix theme color for contacts

Alright, we are ready for review :)
Attachment #8471216 - Flags: review?(francisco)
Attachment #8471216 - Flags: review?(francisco) → review+
master: https://github.com/mozilla-b2g/gaia/commit/b1a50aa8345029d4ef61b317c62be7e9a00d9686
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Attached image IMAG0008.jpg
This issue has been successfully verified on Flame 2.1:
Gaia-Rev        1bdd49770e2cb7a7321e6202c9bf036ab5d8f200
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/db893274d9a6
Build-ID        20141125001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
You need to log in before you can comment on or make changes to this bug.