1041902 - [Cost Control] Customize Status Bar Color

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

For 2.1, each app will have a customized status bar color. Work to support this was completed in bug 1013913 and bug 1033364. Now we must update each of the apps with the appropriate meta tags as specified in the visual spec:

https://bug1041625.bugzilla.mozilla.org/attachment.cgi?id=8460033

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [Gaia PR] add theme color for cost control

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [screenshot] Cost Control Theme

Comment 3

[Salvador de la Puente González [:salva]]

Comment on attachment 8471228 [details] [review]
[Gaia PR] add theme color for cost control

Cool and nice! Thank you.

Comment 4

[Eric Pang [:epang] UX]

Comment on attachment 8471230 [details]
[screenshot] Cost Control Theme

Looks good, can't believe this is finally happening :D.
But again, this is just for the status bar bg and status bar icons right?  
Cause the RB field isn't to spec. Thanks!

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Eric Pang [:epang] from comment #4)
> Comment on attachment 8471230 [details]
> [screenshot] Cost Control Theme
> 
> Looks good, can't believe this is finally happening :D.
> But again, this is just for the status bar bg and status bar icons right?  
> Cause the RB field isn't to spec. Thanks!

Yeah, that will need to be fixed separately in the system app. I believe we are tracking that in bug 1052488.

master: https://github.com/mozilla-b2g/gaia/commit/de78700b715d5cab59e680ba69545e4fff18846f

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [screenshot] CostControl updated theme

Eric, now that the spec has changed to take into account the .1 opacity on the statusbar, we should probably revisit the light colored apps. What do you think, is this change better than attachment 8471230 [details]?

Comment 7

[Eric Pang [:epang] UX]

(In reply to Michael Henretty [:mhenretty] from comment #6)
> Created attachment 8476185 [details]
> [screenshot] CostControl updated theme
> 
> Eric, now that the spec has changed to take into account the .1 opacity on
> the statusbar, we should probably revisit the light colored apps. What do
> you think, is this change better than attachment 8471230 [details]?

Hey Michael, I updated the spec to account for this.  But it's looking really light now, with the 10% black overlay I was expected it to be closer to the first implementation.  Is there a different overlay or no overlay on light apps?

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Ok, we need to adjust the color here based on the lastest spec.

https://bug1041625.bugzilla.mozilla.org/attachment.cgi?id=8476849

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [Gaia PR] revist cost control theme

Hi Salvador, sorry we gotta do another review here.

Comment 10

[Salvador de la Puente González [:salva]]

Comment on attachment 8477052 [details] [review]
[Gaia PR] revist cost control theme

Please, remove the former one in index.html and you can merge.

Thank you!

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Salvador de la Puente González [:salva] from comment #10)
> Comment on attachment 8477052 [details] [review]
> [Gaia PR] revist cost control theme
> 
> Please, remove the former one in index.html and you can merge.
> 
> Thank you!

Good catch!

master: https://github.com/mozilla-b2g/gaia/commit/b63c3785a07c8da659b7f68e2f1a2e0b2bb58884