The default bug view has changed. See this FAQ.

Indicate that a comment is required when selecting a value which has an auto-comment configured

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
Extensions: TrackingFlags
--
enhancement
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sylvestre, Assigned: glob)

Tracking

Production

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
It would be nice if we could have an automatic focus to the regular bugzilla textarea when selecting relnotes? or tracking-firefoxXX? are used.

Please consider that we may want to disable this feature if it is a pain for users (I guess people don't like when the focus changes).
(Assignee)

Updated

3 years ago
Summary: Autofocus on the comment textarea when selecting relnotes? → Autofocus on the comment textarea when selecting a value which has an auto-comment configured
(Assignee)

Updated

3 years ago
No longer depends on: 853108
(Reporter)

Comment 1

3 years ago
Or, maybe a better solution, instead of changing the focus, maybe open a new textarea close to tracking flag to make sure that the user sees it (without the focus change)
(Assignee)

Comment 2

3 years ago
(In reply to Sylvestre Ledru [:sylvestre] from comment #1)
> Or, maybe a better solution, instead of changing the focus, maybe open a new
> textarea close to tracking flag to make sure that the user sees it (without
> the focus change)

i think that focusing and scrolling the textarea is a better solution than creating/moving the comment textarea.


another option which may be simpler is displaying a short notification next to the flag..

  [ relnotes-firefox? ] (comment required)

clicking on the notification scrolls the comment textarea into view and focuses is.
(Reporter)

Comment 3

3 years ago
Yeh, you like better your proposal :)
(Assignee)

Updated

3 years ago
Assignee: nobody → glob
(Reporter)

Comment 4

3 years ago
FYI, most of the people don't see the autocomment. This gives stuff like:
https://bugzilla.mozilla.org/show_bug.cgi?id=1048099#c1
(Assignee)

Comment 5

3 years ago
Created attachment 8467583 [details] [diff] [review]
1041964_1.patch
Attachment #8467583 - Flags: review?(dkl)
Comment on attachment 8467583 [details] [diff] [review]
1041964_1.patch

Review of attachment 8467583 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/TrackingFlags/web/js/tracking_flags.js
@@ +52,4 @@
>          return;
> +    }
> +    // create "comment required"
> +    var span = document.createElement('span');

Need to check to see if this span is already present, otherwise if the user first selects one value with a required comment, but then selects another, it keeps adding another (comment required) each time.
Attachment #8467583 - Flags: review?(dkl) → review-
(Reporter)

Updated

3 years ago
Duplicate of this bug: 1051186
(Assignee)

Comment 8

3 years ago
Created attachment 8470631 [details] [diff] [review]
1041964_2.patch
Attachment #8467583 - Attachment is obsolete: true
Attachment #8470631 - Flags: review?(dkl)
Comment on attachment 8470631 [details] [diff] [review]
1041964_2.patch

Review of attachment 8470631 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8470631 - Flags: review?(dkl) → review+
(Assignee)

Comment 10

3 years ago
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   cf5c164..2957d62  master -> master
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Summary: Autofocus on the comment textarea when selecting a value which has an auto-comment configured → Indicate that a comment is required when selecting a value which has an auto-comment configured
You need to log in before you can comment on or make changes to this bug.