1041964 - Indicate that a comment is required when selecting a value which has an auto-comment configured

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, enhancement)

Description

[Sylvestre Ledru [:Sylvestre]]

It would be nice if we could have an automatic focus to the regular bugzilla textarea when selecting relnotes? or tracking-firefoxXX? are used.

Please consider that we may want to disable this feature if it is a pain for users (I guess people don't like when the focus changes).

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Or, maybe a better solution, instead of changing the focus, maybe open a new textarea close to tracking flag to make sure that the user sees it (without the focus change)

Comment 2

[:glob ✱]

(In reply to Sylvestre Ledru [:sylvestre] from comment #1)
> Or, maybe a better solution, instead of changing the focus, maybe open a new
> textarea close to tracking flag to make sure that the user sees it (without
> the focus change)

i think that focusing and scrolling the textarea is a better solution than creating/moving the comment textarea.


another option which may be simpler is displaying a short notification next to the flag..

  [ relnotes-firefox? ] (comment required)

clicking on the notification scrolls the comment textarea into view and focuses is.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Yeh, you like better your proposal :)

Comment 4

[Sylvestre Ledru [:Sylvestre]]

FYI, most of the people don't see the autocomment. This gives stuff like:
https://bugzilla.mozilla.org/show_bug.cgi?id=1048099#c1

Comment 5

[:glob ✱]

Attachment: 1041964_1.patch

Comment 6

[David Lawrence [:dkl]]

Comment on attachment 8467583 [details] [diff] [review]
1041964_1.patch

Review of attachment 8467583 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/TrackingFlags/web/js/tracking_flags.js
@@ +52,4 @@
>          return;
> +    }
> +    // create "comment required"
> +    var span = document.createElement('span');

Need to check to see if this span is already present, otherwise if the user first selects one value with a required comment, but then selects another, it keeps adding another (comment required) each time.

Comment 8

[:glob ✱]

Attachment: 1041964_2.patch

Comment 9

[David Lawrence [:dkl]]

Comment on attachment 8470631 [details] [diff] [review]
1041964_2.patch

Review of attachment 8470631 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 10

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   cf5c164..2957d62  master -> master