Closed
Bug 1042052
Opened 7 years ago
Closed 7 years ago
The TextureClients on white and on back should always be of the same type.
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: nical, Assigned: nical)
References
Details
Attachments
(1 file)
18.58 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
In rare occasions (most likely when running out of video memory) we may fail to allocate a TextureClient in the non-tiled ContentClient. When this happens we try to fallback to a BufferTextureClient (backed by either plain memory or shmem). This can cause the two component alpha planes to not be of the same type in the compositor side and cause one to be a BigImageIterator while the other isn't. It would be needlessly complicated to support this on the compositor side so we should always make sure both planes are of the same type on the client side.
Assignee | ||
Comment 1•7 years ago
|
||
try push: https://tbpl.mozilla.org/?tree=Try&rev=bae7aed0999c
Assignee: nobody → nical.bugzilla
Attachment #8460313 -
Flags: review?(sotaro.ikeda.g)
Comment 2•7 years ago
|
||
Comment on attachment 8460313 [details] [diff] [review] Add TextureClient::CreateSimilar and use that in ContentClient for component alpha Review of attachment 8460313 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, this could simplify the situation. "review+" if tryserver test is passed.
Attachment #8460313 -
Flags: review?(sotaro.ikeda.g) → review+
Assignee | ||
Comment 3•7 years ago
|
||
try push: https://tbpl.mozilla.org/?tree=Try&rev=17f60d6a825b
Assignee | ||
Comment 4•7 years ago
|
||
fixed the windows build error, windows-only try push: https://tbpl.mozilla.org/?tree=Try&rev=07d20210f5f8
Assignee | ||
Comment 5•7 years ago
|
||
successful windows try push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=c28cd7aba86d
Assignee | ||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/780188e2dab7
https://hg.mozilla.org/mozilla-central/rev/780188e2dab7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•