Closed Bug 1042143 Opened 7 years ago Closed 7 years ago

Schedule mochitest-plain on linux64-mulet on all branches

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jgriffin, Assigned: jgriffin)

References

Details

Attachments

(1 file, 1 obsolete file)

We're nearly to a green set of mochitest-plain and mochitest-devtools on fig; we should schedule linux64 mulet builds and the above tests against trunk branches as soon as those go green.

We can start working on the necessary patches in the interim.
mochitest-devtools is still a bit flakey
Summary: Schedule mochitest-plain and mochitest-devtools on linux64-mulet on all branches → Schedule mochitest-plain on linux64-mulet on all branches
This passes test-masters.sh locally.
Attachment #8460433 - Flags: review?(jlund)
Assignee: nobody → jgriffin
Depends on: 1042270
I am on buildduty and didn't get to this in my queue today.

Tomorrow I will get you a review. My concern here is that we will be adding a few more builders and enabling by default on try in our already bottlenecked linux64 test pool. There was another recent wall up on enabling more builders so let me grab a consensus on our current state.

I'll get back to you on both of those things by tomorrow am.
Comment on attachment 8460433 [details] [diff] [review]
Schedule Mulet builds and mochitest-plain on linux64 on trunk branches,

Review of attachment 8460433 [details] [diff] [review]:
-----------------------------------------------------------------

hmm, so I think the build jobs look good (mozilla/config.py).

But with test jobs, and I may be wrong, I think we may have unwanted side effects. i.e. for test jobs: this patch would introduce linux mulet suites on release branches and also introduce suites like jittest and in some cases, web-platform-tests and mozbase.

man, I spent a lot of time looking at this. this is messy, let's dive in:

so I think lines like:
http://mxr.mozilla.org/build/source/buildbot-configs/mozilla-tests/config.py#1811
http://mxr.mozilla.org/build/source/buildbot-configs/mozilla-tests/config.py#1799
http://mxr.mozilla.org/build/source/buildbot-configs/mozilla-tests/config.py#1822

make it so we add these suites to all our platforms. But do we want mulet to be running these in cedar?

then there is this line:
http://mxr.mozilla.org/build/source/buildbot-configs/mozilla-tests/config.py#1791

which will enable jittest across every single one of our platforms??!?

IIUC, then this is disheartening. With dependent wide spread loops, it is very hard to not only read what things are doing but also to change it (especially without adding more loops).

I think we are going to need an overhaul very soon to mozilla-tests/config.py but that is clearly out of scope here. At any rate, unless I'm way off, I don't think we can land this patch.

::: mozilla-tests/config.py
@@ -1923,2 @@
>          continue
> -    for platform in ('linux64-mulet', 'macosx64-mulet'):

so by removing linux64-mulet here I think we are saying leave linux64-mulet in every single branch.

IIUC I think we would need somethign like:

# enable linux64-mulet only on 34+
for name, branch in items_before(BRANCHES, 'gecko_version', 34):
    for platform in ('linux64-mulet',):
        if platform in BRANCHES[name]['platforms']:
            del BRANCHES[name]['platforms'][platform]
Attachment #8460433 - Flags: review?(jlund) → review-
Thanks for the feedback.  I figured out I could execute config.py to get a full list of builders, so I think this fixes all of the problems you noted.
Attachment #8461748 - Flags: review?(jlund)
Attachment #8460433 - Attachment is obsolete: true
Comment on attachment 8461748 [details] [diff] [review]
Schedule Mulet builds and mochitest-plain on linux64 on trunk branches,

Review of attachment 8461748 [details] [diff] [review]:
-----------------------------------------------------------------

awesome. lgtm.

this will introduce 20 more jobs across our branches:

[dev_master] jlund@Hastings163:~VIRTUAL_ENV/test-master
> wc -l ../builderlists/240714_mulet_try-clean
   14143 ../builderlists/240714_mulet_try-clean

[dev_master] jlund@Hastings163:~VIRTUAL_ENV/test-master
> wc -l ../builderlists/240714_mulet_try-dirty
   14163 ../builderlists/240714_mulet_try-dirty
Attachment #8461748 - Flags: review?(jlund) → review+
Thanks, will land this early next week.
Comment on attachment 8461748 [details] [diff] [review]
Schedule Mulet builds and mochitest-plain on linux64 on trunk branches,

https://hg.mozilla.org/build/buildbot-configs/rev/307ee03aa353
Attachment #8461748 - Flags: checked-in+
Sheriffs, this new platform and mochitest-plain on that platform should go live with the next reconfig.
(In reply to Jonathan Griffin (:jgriffin) from comment #9)
> Sheriffs, this new platform and mochitest-plain on that platform should go
> live with the next reconfig.

Thank you for the heads up :-)

These are looking pretty green:
https://tbpl.mozilla.org/?tree=Fig&jobname=%28Linux|ubuntu%29.*%28build|mochitest-\d+%29
something(s) here went to production today
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.