1042270 - Add Mulet compatibility to mochitest mach target

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Jonathan Griffin (:jgriffin)]

We're nearly ready to enable Mulet builds and mochitests across trunk branches, but we need to make sure developers can run the tests easily.

Currently, ./mach mochitest-plain fails on mulet with the error:

It looks like you tried to run a mach command from an invalid context. The mochitest-plain
command failed to meet the following conditions: 

  is_firefox - Must have a Firefox build.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Add is_mulet condition to mach,

With this, mochitest-plain works fine locally with mach.

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8460567 [details] [diff] [review]
Add is_mulet condition to mach,

Review of attachment 8460567 [details] [diff] [review]:
-----------------------------------------------------------------

Nice that it works out of the box!

::: python/mozbuild/mozbuild/base.py
@@ +619,5 @@
> +            return cls.substs.get('MOZ_BUILD_APP') == 'b2g/dev'
> +        return False
> +
> +    @staticmethod
> +    def is_firefox_or_mulet(cls):

Personally I would define is_firefox_or_mulet in the mach_commands.py instead of here, but I guess if it will be used frequently by several different mach_commands.py files, then it's ok.

Comment 3

[Jonathan Griffin (:jgriffin)]

It will be used in probably three different mach_commands.py files, so leaving as-is.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c86306df8c2

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9c86306df8c2