Closed Bug 1042169 Opened 11 years ago Closed 11 years ago

django-multidb-router missing from requirements.txt

Categories

(Socorro :: Infra, task)

Product:
Socorro
Component:
Infra
Platform:
x86_64
Linux
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bramwelt, Assigned: peterbe)

References

Details

Running `make bootstrap` in a clean Vagrant VM fails with: 'Improperly Configured: Error importing database router PinningMasterSlaveRouter: "No module named multidb"' This is resolved by pip installing 'django-multidb-router'. 'django-multidb-router' should be added to requirements.txt and pinned to what playdoh-lib included before 965589 was resolved.
That's strange. I need to look up what `make bootstrap` does differently. We don't need django-multidb-router and the bug is that it gets required by something.
This is the middleware class that could cause that error: multidb.middleware.PinningRouterMiddleware Basically, it should not by MIDDLEWARE_CLASSES.
multidb.middleware.PinningRouterMiddleware is not listed in any MIDDLEWARE_CLASSES. It is however required by funfactory, which we rely on.
My bad, some other thing is requiring multidb which we ought to get rid of.
Assignee: nobody → peterbe
funfactory requires multidb and sets DATABASE_ROUTERS to 'multidb.PinningMasterSlaveRouter' https://github.com/mozilla/funfactory/blob/afaa4934297c79c98cc18b106ad73ff92ff74472/funfactory/settings_base.py#L31 Unsetting this (setting to an empty tuple) should fix the issue.
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/f27c3abfad6c25dd2f1c5af106b50f4012825bdd fixes bug 1042169 - unset DATABASE_ROUTERS in settings https://github.com/mozilla/socorro/commit/8e22e30fe002138d0f08d6b7db80a31e0064b9a6 Merge pull request #2235 from peterbe/bug-1042169-django-multidb-router-missing-from-requirementstxt fixes bug 1042169 - unset DATABASE_ROUTERS in settings
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95
You need to log in before you can comment on or make changes to this bug.