Closed
Bug 965589
Opened 10 years ago
Closed 10 years ago
replace vendored libs with a requirements file
Categories
(Socorro :: Webapp, task)
Tracking
(Not tracked)
RESOLVED
FIXED
95
People
(Reporter: lonnen, Assigned: peterbe)
References
Details
The webapp is a hodgepodge of vendored libraries, submoduled libraries, and a requirements file. Replace all that with a requirements file. This will mean moving off of playdoh, but it's holding us back for little or no benefit.
Reporter | ||
Comment 1•10 years ago
|
||
My initial pull request was to aggressive. Replacing vendor libs is fine, but it's outside of the scope of this bug to try and rip out the funfactory library at the same time.
Comment 2•10 years ago
|
||
We can unify the virtualenvs separate from replacing the vendored libs (which I agree is a good idea!) Dealing with two virtualenvs is turning out to be the more problematic thing in practice, submodules are kind of gross but aren't e.g. stopping us from running on heroku.
No longer blocks: 965590
Assignee | ||
Comment 3•10 years ago
|
||
Yes, I plan to drop ./vendor entirely and replaced with the main socorro requirements.txt.
Assignee: nobody → peterbe
Assignee | ||
Comment 4•10 years ago
|
||
PR https://github.com/mozilla/socorro/pull/2231 There might be a lot more to do on the code in terms of cleaning things up and figuring out what other "crap" we don't need from funfactory that we don't need.
Comment 5•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/c44c535575c1d1e856a329660466901ebb97ec5f fixes bug 965589 - replace vendored libs with a requirements file, r=@bramwelt https://github.com/mozilla/socorro/commit/f4cff26cee7177ff37c61f4ee347bb360da1ccb2 Merge pull request #2231 from peterbe/bug-965589-replace-vendored-libs-with-a-requirements-file fixes bug 965589 - replace vendored libs with a requirements file
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•10 years ago
|
Target Milestone: --- → 95
You need to log in
before you can comment on or make changes to this bug.
Description
•