1042197 - [Email] Close IMAP connection immediately after periodic sync

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Marcus Cavanaugh [:mcav]]

Per discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1018828#c15

Comment 1

[Dylan Oliver [:doliver]]

Note for triage: this is a dependent bug of the formerly blocking bug 1018828. We converted that one to a meta bug and the actual work will happen here and the in the sibling bugs. Requesting blocking here for improvements to email sync stability in 2.0.

Comment 2

[Marcus Cavanaugh [:mcav]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/325

This patch introduces two connection-killing behaviors:

- After 30 seconds of not receiving any data from the IMAP connection, the connection is terminated.

- After a folder is done with a connection, we check to see if there are (no pending connection requests && no pending server jobs). If not, kill the connection. I'm not 100% certain that this logic captures exactly what we're looking for, so please verify that that conditional is actually what care about.

For testing the no-pending-jobs kill behavior, my initial pass at trying to update the expect_releaseConnection/expect_deadConnection expectations for each case proved somewhat complex because some tests hold slices open and others do not; presently I just added a flag to shut off the behavior for most unit tests, and added a test to verify the behavior (and flip on the flag) in test_imap_kill_unused_connections.

Comment 3

[Marcus Cavanaugh [:mcav]]

I've fixed up the tests/nits per your feedback. Tests pass locally for me. Thanks!

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8461089 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/325

Looks great, thanks!  Just two minor nits to fix before landing.

Comment 5

[Marcus Cavanaugh [:mcav]]

Gaia master: https://github.com/mozilla-b2g/gaia/commit/fadfafa17f5175203b8b9457bfb95e5816f54f58

gelam: https://github.com/mozilla-b2g/gaia-email-libs-and-more/commit/fa6b58bd7acefc8893096403808a105b6e91c76a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/fb1154e985eaf982fffe334d913057f34eb31973