1042423 - Do css background clipping using DisplayItemClip

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Having background painting do it's own clipping causes issues with bug 1039020, and it also stops us from being able to convert backgrounds into color/image layers in many cases.

We already have the all infrastructure to represent all the clips needed, so we might as well use it.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Part 1: Tidy up GetBackgroundClip and expose it

Just moves some duplicated code into this function and makes it publicly accessible.

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Part 2: Add DisplayItemClip constructor for rect + rounded rect

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Part 3: Don't build inactive mask layers

Comment 4

[Matt Woodrow (:mattwoodrow)]

Attachment: Part 4: Clip background display items using DisplayItemClip

Comment 5

[Matt Woodrow (:mattwoodrow)]

Attachment: Part 5: Remove PaintBackgroundColor

This no longer does anything useful, and duplicated a lot of code from PaintBackground.

Comment 6

[Matt Woodrow (:mattwoodrow)]

https://tbpl.mozilla.org/?tree=Try&rev=d1610841137d

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8460728 [details] [diff] [review]
Part 4: Clip background display items using DisplayItemClip

Review of attachment 8460728 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsCSSRendering.cpp
@@ +2853,5 @@
>    // renderer draw the background and bail out.
>    const nsStyleDisplay* displayData = aForFrame->StyleDisplay();
>    if (displayData->mAppearance) {
> +    nsITheme *theme = aForFrame->PresContext()->GetTheme();
> +    if (theme && theme->ThemeSupportsWidget(aForFrame->PresContext(), aForFrame,

create a local variable for PresContext(). it's not free.

::: layout/base/nsDisplayList.cpp
@@ +1896,5 @@
>  
> +  bool willPaintBorder = !isThemed &&
> +                         (!aFrame->StyleBorder()->mBoxShadow ||
> +                          !aFrame->StyleBorder()->mBoxShadow->HasShadowWithInset(true)) &&
> +                         aFrame->StyleBorder()->HasBorder();

fix indent

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8460730 [details] [diff] [review]
Part 5: Remove PaintBackgroundColor

Review of attachment 8460730 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsDisplayList.cpp
@@ +2634,2 @@
>    nsRect borderBox = nsRect(ToReferenceFrame(), mFrame->GetSize());
> +  

trailing whitespace

Comment 9

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc7ae0a5d9b8
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3dbf9a42955
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b684b43edd9
https://hg.mozilla.org/integration/mozilla-inbound/rev/a23a7e056b1a
https://hg.mozilla.org/integration/mozilla-inbound/rev/06b540d3667a

Comment 10

[Matt Woodrow (:mattwoodrow)]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/0bad0d95c5b2

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dc7ae0a5d9b8
https://hg.mozilla.org/mozilla-central/rev/a3dbf9a42955
https://hg.mozilla.org/mozilla-central/rev/9b684b43edd9
https://hg.mozilla.org/mozilla-central/rev/a23a7e056b1a
https://hg.mozilla.org/mozilla-central/rev/06b540d3667a
https://hg.mozilla.org/mozilla-central/rev/0bad0d95c5b2