box-shadow regression

VERIFIED FIXED in Firefox 34

Status

()

Core
Layout
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: mats, Assigned: mattwoodrow)

Tracking

({regression, testcase})

34 Branch
mozilla34
x86_64
All
regression, testcase
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(firefox33 unaffected, firefox34+ verified)

Details

(Whiteboard: [testday-20141003], URL)

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Created attachment 8475991 [details]
screenshot

It appears there's a regression on trunk in rendering one of the examples on
the 'box-decoration-break' MDN page:
https://mdn.mozillademos.org/files/8191/box-decoration-break-inline-extreme.html

ACTUAL RESULT
see attached screenshot

EXPECTED RESULT
https://mdn.mozillademos.org/files/8189/box-decoration-break-slice-inline-2.png

PLATFORMS AND BUILDS TESTED
Bug occurs in Nightly 34.0a1 (2014-08-20) on Linux64
It works fine in a local Aurora debug build.

The example worked fine 2014-07-12 when I made the screenshot for the MDN page:
https://developer.mozilla.org/en-US/docs/Web/CSS/box-decoration-break
(Reporter)

Updated

4 years ago
Keywords: testcase

Comment 1

4 years ago
[Tracking Requested - why for this release]:regression


Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/326c91338df0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140722220945
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/06b540d3667a
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140722222448
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=326c91338df0&tochange=06b540d3667a

Regressed by: Bug 1042423
Blocks: 1042423
status-firefox33: --- → unaffected
status-firefox34: --- → affected
tracking-firefox34: --- → ?
Keywords: regressionwindow-wanted
OS: Linux → All
Version: unspecified → 34 Branch
Matt, could you take a look at this?
Flags: needinfo?(matt.woodrow)
(Assignee)

Updated

4 years ago
Assignee: nobody → matt.woodrow
Flags: needinfo?(matt.woodrow)
(Assignee)

Comment 3

4 years ago
Created attachment 8477198 [details] [diff] [review]
Clip correctly when we have continuations

This is a regression from http://hg.mozilla.org/integration/mozilla-inbound/rev/dc7ae0a5d9b8

We previously called BoxDecorationRectForBorder outside of GetBackgroundClip and passed the result in as aBorderArea. Now that we compute it inside the function we need to replace uses of aBorderArea with clipBorderArea.

No idea how to write a reftest for this.
Attachment #8477198 - Flags: review?(roc)
tracking-firefox34: ? → +
(Reporter)

Comment 4

4 years ago
(In reply to Matt Woodrow (:mattwoodrow) from comment #3)
> No idea how to write a reftest for this.

Maybe you can adapt the cited example from the MDN page?
Use the "iM" with the line break in the test and mask
everything except an area around the "i".  Do the same for
the reference but without the line break.
Flags: in-testsuite?
https://hg.mozilla.org/mozilla-central/rev/e1d9104a958f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox34: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
QA Whiteboard: [good first verify]

Comment 7

4 years ago
I can verify it's fixed using Windows 7 and the latest Aurora build (Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0)

Updated

4 years ago
Whiteboard: [testday-20141003]
Thank you Gabriela! I also verified this on Ubuntu 13.04 x64 and Mac OS X 10.9.4, and looks fixed in the latest 34 Aurora (October 6th build).
Status: RESOLVED → VERIFIED
status-firefox34: fixed → verified
You need to log in before you can comment on or make changes to this bug.