1042425 - Limit the number of history results shown during pre-load

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Eric Edens [:eedens]]

We show search history cards when the search activity for loads. Right now it shows all history items -- there should be a sensible limit.

This will use the change from bug 1040994.

Comment 1

[:Margaret Leibovic]

Attachment: Limit the number of search history results displayed

Sorry, I didn't notice that you were already assigned. Hopefully you don't already have a patch somewhere!

This was a bit annoying to test because MockHistoryProvider doesn't support limits, but I don't think it's worth updating that. This works with Fennec!

Comment 2

[Eric Edens [:eedens]]

Comment on attachment 8464904 [details] [diff] [review]
Limit the number of search history results displayed

Review of attachment 8464904 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good -- let's pull out the constant before landing :)

::: mobile/android/search/java/org/mozilla/search/PreSearchFragment.java
@@ +40,5 @@
> +
> +    // Limit search history query results to 5 items. This value matches the number of search
> +    // suggestions we return in SearchFragment.
> +    private static final Uri SEARCH_HISTORY_URI =
> +            SearchHistory.CONTENT_URI.buildUpon().appendQueryParameter(BrowserContract.PARAM_LIMIT, "5").build();

Can we pull the `5` constant out from here and the code that fetches search suggestions into Constants.java?

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/e15064c8ce6a
https://github.com/ericedens/FirefoxSearch/commit/f1beb11902cd9160e8f46fd43fbfa38cc51098f4

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e15064c8ce6a