104244 - [RFE] add reload this/all tab(s) to context menu

Status: VERIFIED FIXED

(SeaMonkey :: Tabbed Browser, enhancement)

Description

[Quinn Yost (mythdraug)]

Add two item to tab context menu

  "Reload this tab"
  "Reload all tabs"

Reload this tab is not redundant with reload button.  Any tab could
be reloaded, not just the current one.

Comment 1

[Andrew Simmonds]

Attachment: patch to fix

Comment 2

[David Hyatt]

Looks good to me. r/sr=hyatt

Comment 3

[Blake Ross]

+            var l = this.mPanelContainer.childNodes.length;
+            for (var i = 0; i < l; i++)
+              if (this.mTabContainer.childNodes[i] == aTab)
+                this.mPanelContainer.childNodes[i].webNavigation.reload(true);

Why do you have to enumerate the children to find aTab, just to use aTab?  Is
that just to ensure that we have a valid tab, because the same context menu
appears for the tab strip itself?  But if so, shouldn't we be preventing those
items from showing up in the menu at all if the popupNode is the tab strip?  (I
notice Close Tab and Close Other Tabs incorrectly appear in the menu for the tab
strip).

hyatt knows this code better than me, so if he doesn't think it should be
aTab.webNavigation.reload(true), r/sr=me...

Comment 4

[Blake Ross]

(But if we wanted to double check we could always just check the localName, so
it seems like that should be changed.)

Comment 5

[timeless]

checking in for [e-mail]

Comment 6

[timeless]

Checking in resources/content/bindings/tabbrowser.xml;
/cvsroot/mozilla/xpfe/global/resources/content/bindings/tabbrowser.xml,v  <-- 
tabbrowser.xml
new revision: 1.8; previous revision: 1.7
done
Checking in resources/locale/en-US/tabbrowser.dtd;
/cvsroot/mozilla/xpfe/global/resources/locale/en-US/tabbrowser.dtd,v  <-- 
tabbrowser.dtd
new revision: 1.2; previous revision: 1.1
done

Comment 7

[Blake Ross]

timeless, did you resolve my question?

Comment 8

[Quinn Yost (mythdraug)]

thx all

Comment 9

[jag (Peter Annema)]

reload(true) is wrong (it should be some kind of numeric flag).

This code also doesn't deal well with getting called for the tabstrip itself
(see bug 112697). Arguably the context menu code should deal with that, but
that's not the pattern used by the other context menu items.