112697 - Reload Tab from context menu broken for "blank" space on tab bar.

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[sairuh (rarely reading bugmail)]

seen using 2001.11.28.0x-comm bits on linux rh7.2, mac 10.1.1 and winnt.

this is not a problem when there are multiple tabs.

0. make sure that "Hide the tab bar when only one tab is open" is turned *off*.
1. have only one tab displayed in the browser window.
2. bring up context menu for tab bar and select Reload Tab.

expected: the tab should reload.

actual results: no reloading occurs.

interestingly, Reload All Tabs [which really be there, see bug 112695] *does*
reload the tab. also, accel+R works, as does selecting View > Reload from the
main menu.

Comment 1

[Niklas Mehner]

WFM Linux build 2001112712.

The cause for this behavior might be the same as for bug 102551. If you got into
this situation by closing a tab, can you press Ctrl-T, and see if you get 3 open
tabs after that? 

Comment 2

[sairuh (rarely reading bugmail)]

hm, i cannot seem to repro bug 102551 --i open the context menu and select
'close tab' rather quickly, and it still doesn't close. and, so far, i've
haven't gotten into a situation where accel+T has opened 3 tabs at once...

Comment 3

[David Hyatt]

Reassigning to new component owner.

Comment 4

[jag (Peter Annema)]

-> future

Comment 5

[Sergi]

I use Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:0.9.9+) Gecko/20020221
and satisfy described conditions. So, I can see:

1. If I bring up context menu over tab title in tab bar and choose "Reload Tab",
I can see tab reloading.
2. If I bring up context menu over free space of tab bar and choose "Reload
Tab",
I can see no tab reloading.

Reporter: is it behaviour you've detect? If so, I guess, expected result should
be different. I mean, we should expect inactive "Reload Tab" menu item while
context menu was launched over free space of tab bar.

Comment 6

[Andreas Kunz]

In case the reporter means the context menu brought up when the mouse is over an
empty part (no tab) of the tab bar (as assumed in comment #5), then this also
does not work with multible tabs open - which sairuh explicitly denied (the menu
entry does make even less sense, there, anyway).

Context menu when mouse is over the tab itself or the displayed page WFM
(2002111908/Win).

Anyway, comment #5 leads the way to go: the context menu entry for parts of the
tab bar where there is no tab should be greyed out.

Comment 7

[jag (Peter Annema)]

Attachment: Reload focused tab if trying to reload tab from tab strip (like the others do)

This also fixes the reload call to not pass in true anymore (that API never
took a boolean, always some kind of int). Call the reload() method on <browser>
instead to have the right thing happen (net effect is the same, minus an
assertion in debug builds).

Comment 8

[jag (Peter Annema)]

Checked in. Would like this on the branch.

Comment 9

[sairuh (rarely reading bugmail)]

adding branch nomination juju.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 124410 [details] [diff] [review]
Reload focused tab if trying to reload tab from tab strip (like the others do)

a=asa (on behalf of drivers) for checkin to the 1.4 branch.

Comment 11

[Samir Gehani]

adt: nsbeta1-

Comment 12

[Samir Gehani]

a=adt to land on the 1.4 branch.

Comment 13

[Asa Dotzler [:asa]]

mozilla1.4 shipped. unsetting blocking1.4 request.

Comment 14

[Philip Chee]

WFM:

Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.9.1b4pre) Gecko/20090305 SeaMonkey/2.0b1pre

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.21pre) Gecko/20090129 SeaMonkey/1.1.15pre

Also by code inspection FIXED in 
SeaMonkey 1.0.9, Mozilla Suite 1.8b2, Mozilla Suite 1.7.13.