Closed Bug 1042562 Opened 10 years ago Closed 7 years ago

Move facebook specific code from suggestion_bar.js to shared/js/contact.js

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: rik, Unassigned)

References

Details

After bug 1032725, the Contacts library (in shared) is including Facebook results. We should remove that code from suggestion_bar.js. Currently, we're querying the datastore twice (I think). I hope we de-duplicate but I haven't checked. This will greatly simplify our suggestion code.
Assignee: nobody → anthony
Status: NEW → ASSIGNED
Actually, the contacts library is not querying Facebook for this case. It just merges facebook data for contacts stored in mozContacts. I'm putting it back in the pool of bugs to take. This is to move the facebook code from suggestion_bar to contacts.js. It's not really important since suggestion_bar is the only user of findListByNumber at the moment.
Assignee: anthony → nobody
Status: ASSIGNED → NEW
Summary: Remove facebook specific code from suggestion_bar.js → Move facebook specific code from suggestion_bar.js to shared/js/contact.js
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.