1042586 - [Contacts][ICE] Create a DataStore for ICE Contacts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Michał Budzyński (:michalbe)]

We need a DataStore to share ICE Contacts with Dialer.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Perhaps in this task we could create a tiny helper library to read and write for contacts, but also could be used in Dialer to check what are the ice contacts?

Comment 2

[Michał Budzyński (:michalbe)]

Are we moving it to this sprint?

Comment 3

[Anthony Ricaud (:rik)]

That would be lovely yes, so we can start our Dialer implementation in Sprint 2.

Comment 4

[Michał Budzyński (:michalbe)]

OK, I'll need to give some love to Haida next week, but I hope I'll find time for this as well.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to pr 22307

Hi folks, that's a version of the utility library, pretty simple I hope, usable for both contacts and dialer.

Comment 6

[Michał Budzyński (:michalbe)]

Great, give me a minute to finish thing I work on and I'm getting to review.

Comment 7

[Anthony Ricaud (:rik)]

Comment on attachment 8464635 [details] [review]
Pointer to pr 22307

f+ on the API although I have naming suggestions.

Comment 8

[Michał Budzyński (:michalbe)]

Comment on attachment 8464635 [details] [review]
Pointer to pr 22307

R+

Great job, only some nits on GH (I agree with most of the things Antony said, I just didn't want to duplicate his comments). I was not able to test this patch on the phone (i will when Bug 1042584 will be ready), but tests passed and everything looks reasonable.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Updated the PR with the suggestions, just waiting for gaia-try to get a green.

Thanks guys for the feedback!

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/arcturus/gaia/commit/8e4a87f49bd3514aec29756f3c88ed49ca8b84d0