Closed
Bug 1042586
Opened 10 years ago
Closed 10 years ago
[Contacts][ICE] Create a DataStore for ICE Contacts
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S1 (1aug)
People
(Reporter: mbudzynski, Assigned: arcturus)
References
Details
Attachments
(1 file)
We need a DataStore to share ICE Contacts with Dialer.
Assignee | ||
Comment 1•10 years ago
|
||
Perhaps in this task we could create a tiny helper library to read and write for contacts, but also could be used in Dialer to check what are the ice contacts?
Comment 3•10 years ago
|
||
That would be lovely yes, so we can start our Dialer implementation in Sprint 2.
Reporter | ||
Comment 4•10 years ago
|
||
OK, I'll need to give some love to Haida next week, but I hope I'll find time for this as well.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → francisco
Assignee | ||
Comment 5•10 years ago
|
||
Hi folks, that's a version of the utility library, pretty simple I hope, usable for both contacts and dialer.
Attachment #8464635 -
Flags: review?(mbudzynski)
Attachment #8464635 -
Flags: feedback?(anthony)
Reporter | ||
Comment 6•10 years ago
|
||
Great, give me a minute to finish thing I work on and I'm getting to review.
Comment 7•10 years ago
|
||
Comment on attachment 8464635 [details] [review] Pointer to pr 22307 f+ on the API although I have naming suggestions.
Attachment #8464635 -
Flags: feedback?(anthony) → feedback+
Reporter | ||
Comment 8•10 years ago
|
||
Comment on attachment 8464635 [details] [review] Pointer to pr 22307 R+ Great job, only some nits on GH (I agree with most of the things Antony said, I just didn't want to duplicate his comments). I was not able to test this patch on the phone (i will when Bug 1042584 will be ready), but tests passed and everything looks reasonable.
Attachment #8464635 -
Flags: review?(mbudzynski) → review+
Assignee | ||
Comment 9•10 years ago
|
||
Updated the PR with the suggestions, just waiting for gaia-try to get a green. Thanks guys for the feedback!
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → 2.1 S1 (1aug)
Assignee | ||
Comment 10•10 years ago
|
||
Landed: https://github.com/arcturus/gaia/commit/8e4a87f49bd3514aec29756f3c88ed49ca8b84d0
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•