1042590 - At small window widths commit descriptions are truncated more than on TBPL

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

Filed from bz's comments on dev.platform:

> 2)  It seems to use a narrower space than tbpl for the patch 
> descriptions; at my window width and font size I don't even see the 
> entire bug number for most commits....

Some thoughts:
1) There are UI elements we can cut out / tweak whitespace or font sizes etc to gain some screen estate. eg the "arrow" button duplicates the SHA link to a certain extent and so should just be removed.
2) Failing that, it's always going to be a compromise between making the job results wrap vs making the commit messages be truncated. 
3) Perhaps we could make the commit messages wrap too?
4) Since the commit messages can be toggled off - perhaps we should prioritise them _slightly_ more in terms of #2, given that people can always turn them off if the wrapping of the results is an issue.
5) Alternatively, perhaps we could have a resizable divider that users can change as desired (bonus points for the size of this saving in their logged-in profile).

Comment 1

[Ed Morley [:emorley]]

(In reply to Ed Morley [:edmorley] from comment #0)
> 1) There are UI elements we can cut out / tweak whitespace or font sizes etc
> to gain some screen estate. eg the "arrow" button duplicates the SHA link to
> a certain extent and so should just be removed.

Bug 1042592 for the arrow button duplicating the SHA link.

Comment 2

[Boris Zbarsky [:bzbarsky]]

For what it's worth, at my window size I see about 400px of horizontal space for the changeset ID plus commit description on tbpl.  On treeherder it's 300px, and the arrow icon takes up 25px of that, so really it's 275px.

Note that this is even though treeherder overflows to the right off my viewport (the min-width it sets on .th-content is larger than my window width), so I have to scroll to see all the job results anyway.  :(

The actual horizontal space treeherder has for the job results (the second column of the results table) is 507px.  The corresponding space on tbpl is 270px, but the display tbpl uses per-job seems to take up a bit less space, both horizontally and vertically, so in practice I see only one platform more on treeherder than on tbpl for a more or less completed push.  For uncompleted pushes I see more on tbl, because on treeherder most of the the platform names wrap to a new line and make every platform two lines tall.

Comment 3

[Jonathan French (:jfrench)]

I'll pose some potential improvements with an example here as far as the content itself goes:

before
85135c5c6ba8 [icon] Joshua Cranmer "Bug 1040009": Add support for comm-central applications..."

proposed
- short 7-character SHA onscreen, full SHA on hover
- arrow removal as requested by Ed (hg link would no longer be available?)
- removal of "Bug " preceding the bug number (since its implicit, and we may eventually link to Git Issues, who knows..)
- regex'd user name condensed to first letter of first name, full last name
- use of ":" for separators if needed
- removal of white space where possible

after
85135c5 jcranmer 1040009:Add support for comm-central applications to --enable-application in.."


This may help address bz's initial customer problem, buying you more space independent of other possible changes to UI containers or other UI affordances.

Comment 4

[Ed Morley [:emorley]]

(In reply to Jonathan French (:jfrench) from comment #3)
> - arrow removal as requested by Ed (hg link would no longer be available?)

The hg URL would be the target for the SHA, the current SHA target is incorrect (bug 1042592).

Comment 5

[Jonathan French (:jfrench)]

Cool.

I forgot to mention above - I transcribed it a bit inaccurately - but as you can see I'm removing the leading " quoting in the bug string also, (and the trailing quote) in the proposed change. This beneficially removes one more character near the front, and one at the end.

Comment 6

[Cameron Dawson [:camd]]

Hey Ed, what do you think of Jonathan's idea here.  I could do this for now and we can adjust later?

Comment 7

[Ed Morley [:emorley]]

Sounds good to me :-)

Comment 8

[Ed Morley [:emorley]]

Though bug 1042592 is probably higher priority short term than this (and would lead nicely into this).

Comment 9

[Cameron Dawson [:camd]]

https://github.com/mozilla/treeherder-ui/commit/c61b048b9acfc1db6065fbcddc053ac0b3ae17bf

I used some of jfrench's ideas and minimized the size of each line.  And each part has a hover title to give the full description.  several other parts were addressed in other commits (wrapping of platform names, etc).  Please have a look and reopen if it's not satisfactory.

Comment 10

[Cameron Dawson [:camd]]

Also, I wanted to mention a few things that are possibly not obvious:

If you click the count of revisions, that will toggle revisions hidden/shown.  Same for the jobs.  So to see more of the revision info, click the job count button and it'll get all the real-estate.  Also, on hover, the full text of the comment will show.

you can also show/hide all revision/jobs from the button on the toolbar at top.

Comment 11

[Ed Morley [:emorley]]

It looks great thank you! :-)

One small thing I noticed - for people who don't have "Firstname Surname" nothing is shown at all, eg:
http://treeherder-dev.allizom.org/ui/#/jobs?repo=mozilla-inbound&revision=5f66dd3d63f2

-> https://hg.mozilla.org/integration/mozilla-inbound/rev/5f66dd3d63f2

"vladikoff <[e-mail]>"

Perhaps just put "V" in that case? (though it breaks the pretty alignment, but better than nothing :-))

Comment 12

[Ed Morley [:emorley]]

Also for:
https://hg.mozilla.org/mozilla-central/rev/7d956b954dd7
B2G Bumper Bot <...>

We get "BGBB".

Comment 13

[Ed Morley [:emorley]]

And for:
https://hg.mozilla.org/mozilla-central/rev/5fd6428ae179
ffxbld

We get ""

(Though arguably we should change the committer name for that automated push)

Comment 14

[Ed Morley [:emorley]]

For:
https://hg.mozilla.org/mozilla-central/rev/2dd9b2f2ef8f
Adam Roach [:abr] <[e-mail]>

We get:
"Aa"

Comment 15

[Ed Morley [:emorley]]

I've broken out comments 11-14 to bug 1067265, since they are only minor regressions and the bug summary here doesn't reflect what work is left to do.