1043032 - Refine "jump button" appearance (the arrow in search suggestions)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Search Activity, defect, P1)

Description

[:Margaret Leibovic]

This button puts search suggestions in the search bar for further editing. I assume the idea of using an arrow came from Google Now, since that's what they do. In any event, we're just using a text character for this now, but we should probably use a proper icon.

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: XXHDPI - Mobile - Typing 2c.png

Let's try using the + icon we have like this.

I think this makes more sense than the arrow since the user can "add" these suggestions to their input and keep typing, but also the arrows for us have rather primary functions associated with them so I don't want to add more types of arrows to our icon library.

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: prev_jump_hitarea.png

Will attach the icon in a bit but wanted to show what kind of hit area we should aim for. Padding on either side of the icon should be 15 dp, centered vertically.

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: icon_+.zip

MDPI --> XXHDPI

Comment 4

[:Margaret Leibovic]

Attachment: Use "+" icon for jump button in search suggestions

antlam and I were talking about possibly tweaking the padding values in the cards, but we can also move that into a different bug.

Comment 5

[Eric Edens [:eedens]]

Comment on attachment 8469479 [details] [diff] [review]
Use "+" icon for jump button in search suggestions

Review of attachment 8469479 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Before landing, there's a small gingerbread issue where the plus sign is aligned to vertical top instead of vertical middle.

Comment 6

[:Margaret Leibovic]

https://github.com/ericedens/FirefoxSearch/commit/2972042fa624dd51dfc0e3f4b2ba0900b992c87c

fx-team is closed right now, but I'll land there when it re-opens.

Comment 7

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/e6a56626b9f1

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e6a56626b9f1