Closed Bug 1043079 Opened 11 years ago Closed 9 years ago

Add a test that the Android-only 565 codepath in imgFrame::Optimize actually works

Categories

(Core :: Graphics: ImageLib, defect)

Product:
Core
Component:
Graphics: ImageLib
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: seth, Assigned: mwu)

References

Details

I recently pushed a try job which, due to a bad rebase, deleted this line from imgFrame::Optimize: http://mxr.mozilla.org/mozilla-central/source/image/src/imgFrame.cpp#286 Without that DrawSurface call, the 565 codepath is totally busted, but all the tests are still green, even on Android. We should have at least one test that sanity checks that this codepath works. As far as I can tell we can use a pref to force it on, so it should be possible to write such a test: http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxAndroidPlatform.cpp#105
Michael, I suspect you're the person who knows the most about this piece of code.
Flags: needinfo?(mwu)
Taking, but I don't know when I'll be able to get to this.
Assignee: nobody → mwu
Flags: needinfo?(mwu)
Depends on: 1292747
We can consider this fixed, I suppose, since in bug 1292747 we removed that code. =p
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.