1043164 - Loop - Apply visuals to Call log screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Comment 1

[Maria Angeles Oteo (:oteo)]

Setting the corresponding dependencies as this bug blocks all the User Stories included in this meta bug
Bug 1002742 - (loop_call_log) [Meta] for Communication history in Loop Mobile Client (Call Log and Shared URLs) 
and the User Story
Bug 1007937 - [User Story] As a user I would like to be able to make a call directly from an entry of the Loop communication history (aka Call Log)

Comment 2

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 3

[Borja Salguero [:borjasalguero]]

Comment on attachment 8462608 [details] [review]
patch in github

After testing I've just discovered the following issues:
- There is no icon in the bottom bar
- When moving from 'calls' to 'urls' the underlying style is broken
- Title of the entries is broken (line height is not well defined)
- Empty call log/urls styles are not working properly (some overlapping)

Please address them and and ask me to review this again when ready!

Comment 4

[Borja Salguero [:borjasalguero]]

Comment on attachment 8462608 [details] [review]
patch in github

Great job!!! Working as expected, so ready to merge!

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: 08ca4241fedda29c838cd08862194e1eff562c1a