Closed
Bug 1043376
Opened 11 years ago
Closed 11 years ago
[Loop] Add visual design to Settings Panel in Loop App
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: borjasalguero, Assigned: arnau)
References
Details
Attachments
(3 files, 1 obsolete file)
settings.png
Add final design of Settings in Loop App.
|
Reporter | |
Updated•11 years ago
|
Assignee: nobody → borja.bugzilla
|
Assignee | |
Updated•11 years ago
|
Assignee: borja.bugzilla → rnowmrch
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8463304 -
Flags: ui-review?(vpg)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8463306 -
Flags: review?(borja.bugzilla)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8463304 [details]
settings.png
Can you please adjust the copy?
"Call type" change to "CAll mode"
"Clean calls" to "Clean all Calls"
"Clean shared urls" to "Clean Shared links"
And logout button as a grey special button at the bottom of the screen.
Thanks!
Attachment #8463304 -
Flags: ui-review?(vpg) → ui-review-
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #8463328 -
Flags: ui-review?(vpg)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8463304 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8463328 [details]
settings.png
El botón OK, puedes cambiar los textos?
Attachment #8463328 -
Flags: ui-review?(vpg) → ui-review+
|
|
Assignee | |
Comment 7•11 years ago
|
||
(In reply to Victoria Gerchinhoren [:vicky] from comment #6)
> Comment on attachment 8463328 [details]
> settings.png
>
> El botón OK, puedes cambiar los textos?
Please check copy.png https://bugzilla.mozilla.org/attachment.cgi?id=8463333
|
|
Reporter | |
Comment 8•11 years ago
|
||
Adding the dependency due to we need the Layout.css here
Depends on: 1043164
|
|
Reporter | |
Comment 9•11 years ago
|
||
Comment on attachment 8463306 [details] [review]
patch in github
From my side just an issue easy to fix and we're done. I've added Fernando due to this patch needs to be rebase and retest. Thanks!
Attachment #8463306 -
Flags: review?(ferjmoreno)
Attachment #8463306 -
Flags: review?(borja.bugzilla)
Attachment #8463306 -
Flags: review+
|
|
Assignee | |
Comment 10•11 years ago
|
||
Fernando,
I've added:
https://github.com/mozilla-b2g/firefoxos-loop-client/pull/61/files#diff-abb510c96091b0d61e7b3e62b4199de0R45
to fix Borja's comment.
Patch ready for your review ;)
|
||
Updated•11 years ago
|
Attachment #8463306 -
Flags: review?(ferjmoreno) → review+
|
|
Assignee | |
Comment 11•11 years ago
|
||
Merged: 831ebc30f61741a7b07a139882f83efb880dda44
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•