1043182 - IMEContentObserver::CharacterDataChanged() doesn't convert new lines in replaced and inserted text to native new lines

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

The patches of bug496360 causes broken behavior of ChangJie (Taiwan's IME).

0. Focus to textarea element.
1. Type a Chinese character and commit it.
2. Type Enter.
3. Type something.

Then, the new composition is inserted to the end of the first line, not the second line. This only occurs in textarea. Not reproduced in HTML editor.

The reason is, plain text editor doesn't use <br> for line breaks. The content is actually plain text with XP line breaks. However, IMEContentObserver::CharacterDataChanged() doesn't convert the new lines to native new lines at computing the mOldEnd and mNewEnd.

I'm not sure why ChangJie is broken by the patches. Although, this bug has already been there...

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2cb0971fc597

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2cb0971fc597