Closed
Bug 1043307
Opened 10 years ago
Closed 10 years ago
Front camera image is rotated by 180 degree in landscape mode
Categories
(Firefox OS Graveyard :: Gaia::Camera, defect)
Tracking
(blocking-b2g:2.0+, b2g-v1.4 unaffected, b2g-v2.0 verified, b2g-v2.1 verified)
Tracking | Status | |
---|---|---|
b2g-v1.4 | --- | unaffected |
b2g-v2.0 | --- | verified |
b2g-v2.1 | --- | verified |
People
(Reporter: poojas, Assigned: dmarcos)
References
()
Details
(Keywords: regression, Whiteboard: [caf priority: p2][CR 696637])
Attachments
(2 files)
Steps to Reproduce: 1. Open camera 2. Switch to Front Camera 3. Keep the device in Landscape mode and take a snapshot 4. Check thumbnail Or Go to Gallery and check the captured image Actual behavior: Captured image is inverted or rotated by 180 degree Expected behavior: Capture image should be same as that of preview. Device details: QRD 8x10 "gaia 5f8b1b8a2da9e3b531eee817a669f57fa4d9b9c6" "gecko e00f7e464333689fcf54edb4945ece94f97f930b" Version 32.0a2 Build Id 20140717155308
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.0?
Updated•10 years ago
|
Whiteboard: [CR 696637] → [caf priority: p2][CR 696637]
This does occur on the flame Gaia 91986777d0942b63e37fbfeec19d69d6176d6d74 Gecko https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/392054b2e899 BuildID 20140723160206 Version 32.0 ro.build.version.incremental=110 ro.build.date=Fri Jun 27 15:57:58 CST 2014 B1TC00011230 The preview is also upside down as well as the image when you capture it.
status-b2g-v2.0:
--- → affected
Comment 7•10 years ago
|
||
This issue is not reproducible on Flame 1.4. Images taken from front camera are not 180 degrees flipped (upside down). However,
> Expected behavior:
> Capture image should be same as that of preview.
This statement doesn't seem to be true on 1.4. The preview and the final image captured are left and right flipped. So if I have a water bottle in the picture, words on the bottle would appear horizontally flipped in preview/viewfinder (like looking at a mirror), but the captured image would appear normal (words can be read normally).
I've checked on my personal phone which runs Android 4.4.4 and it's the same behavior. So I think this behavior is to be expected.
Tested on:
Device: Flame
Build ID: 20140724070707
Gaia: 6e4eaa5befce9c1812e07bcc78b2138645bdbe7a
Gecko: c55732bd61a2
Version: 30.0 (1.4)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-v1.4:
--- → unaffected
Flags: needinfo?(jmitchell)
Keywords: qawanted
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(jmitchell)
Keywords: regression,
regressionwindow-wanted
Updated•10 years ago
|
QA Contact: pcheng
Comment 8•10 years ago
|
||
(In reply to Pi Wei Cheng [:piwei] from comment #7) > This issue is not reproducible on Flame 1.4. Images taken from front camera > are not 180 degrees flipped (upside down). However, > > > Expected behavior: > > Capture image should be same as that of preview. > > This statement doesn't seem to be true on 1.4. The preview and the final > image captured are left and right flipped. So if I have a water bottle in > the picture, words on the bottle would appear horizontally flipped in > preview/viewfinder (like looking at a mirror), but the captured image would > appear normal (words can be read normally). > > I've checked on my personal phone which runs Android 4.4.4 and it's the same > behavior. So I think this behavior is to be expected. > > Tested on: > Device: Flame > Build ID: 20140724070707 > Gaia: 6e4eaa5befce9c1812e07bcc78b2138645bdbe7a > Gecko: c55732bd61a2 > Version: 30.0 (1.4) > Firmware Version: v122 > User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0 Left/Right Flip seems to be the behavior for photos taken using front camera on my personal phone as well. However, on Flame I am seeing a top/bottom 180 degrees flip with front camera (only on landscape; portrait shows a left/right flip). Mike, any ideas why this is happening?
Flags: needinfo?(mhabicher)
Assignee | ||
Comment 9•10 years ago
|
||
This is a dup and it's a OEM issue. The pictures in flame don't contain the exif orientation flag.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Comment 10•10 years ago
|
||
Removing QA-Wanted tags
QA Whiteboard: [QAnalyst-Triage+]
Keywords: regressionwindow-wanted
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → dmarcos
Assignee | ||
Comment 11•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8462020 -
Flags: review?(jdarcangelo)
Assignee | ||
Comment 12•10 years ago
|
||
Reopening. There's actually a bug on the device orientation flag we pass to the camera. Attached PR to master that can be uplifted to 2.0
Status: RESOLVED → REOPENED
Flags: needinfo?(mhabicher)
Resolution: DUPLICATE → ---
Comment 13•10 years ago
|
||
(In reply to Diego Marcos [:dmarcos] from comment #11) > Created attachment 8462020 [details] [review] > Pull Request See this patch fixes the issue, its not upside down any more.
Comment 15•10 years ago
|
||
Comment on attachment 8462020 [details] [review] Pull Request Looks good to me! No more upside-down selfies :-)
Attachment #8462020 -
Flags: review?(jdarcangelo) → review+
Updated•10 years ago
|
Target Milestone: --- → 2.1 S1 (1aug)
Assignee | ||
Comment 16•10 years ago
|
||
Landed in master: https://github.com/mozilla-b2g/gaia/commit/9c5b09649e937764c2a19177661c9afefa7c981c It should cleanly uplift to 2.0
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Comment 17•10 years ago
|
||
v2.0: https://github.com/mozilla-b2g/gaia/commit/f1186d94f344dc725da4c28257281641f83a2ac1
Updated•10 years ago
|
Flags: in-moztrap?(ychung)
Comment 18•10 years ago
|
||
Found Test Case: https://moztrap.mozilla.org/manage/case/2528/ STR needs to added to verify this bug to the existing test case.
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Comment 19•10 years ago
|
||
New test case written in moztrap: https://moztrap.mozilla.org/manage/case/14201/
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Flags: in-moztrap?(ychung)
Flags: in-moztrap+
Comment 20•10 years ago
|
||
This issue has been verified successfully on Flame 2.0,2.1 See attachment: Verify_video.3gp Reproducing rate: 0/5 Flame 2.0 versions: Gaia-Rev 8d1e868864c8a8f1e037685f0656d1da70d08c06 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/29222e215db8 Build-ID 20141203000201 Version 32.0 Flame 2.1 versions: Gaia-Rev dbaf3e31c9ba9c3436e074381744f2971e15c7bf Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194 Build-ID 20141203001205 Version 34.0
Comment 21•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•