1043328 - Submitting option_collection without opts can break future job insertion

Status: RESOLVED DUPLICATE of bug 1037670

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

Migrated from:
https://github.com/mozilla/treeherder-service/issues/112

lightsofapollo commented on 26 Feb:
{
When submitting jobs without option_collection.opts I noticed some errors like this:

Traceback (most recent call last):
  File "/home/vagrant/treeherder-service/treeherder/webapp/api/views.py", line 126, in use_jobs_model
    return model_func(*args, jm=jm, **kwargs)
  File "/home/vagrant/treeherder-service/treeherder/webapp/api/views.py", line 332, in list
    job["option_collection_hash"]]['opt']
KeyError: u'da39a3ee5e6b4b0d3255bfef95601890afd80709

With the following job collection

[{
      "revision_hash": "...",
      "job": {
        "build_platform": {
          "platform": "2.2",
          "os_name": "android",
          "architecture": "ARMv7",
          "vm": false
        },
        "job_guid": '11111',
        "name": "Testing gaia",
        "reason": "scheduler",
        "job_symbol": "?",
        "submit_timestamp": 1387221298,
        "start_timestamp": 1387221345,
        "end_timestamp": 1387222817,
        "state": "pending",
        "log_references": [],
        "option_collection": {
        }
}]

Looks like this is caused by this: https://github.com/mozilla/treeherder-service/blob/master/treeherder/webapp/api/views.py#L325 which always seems to expect .opt
}


lightsofapollo commented on 26 Feb:
{
As long as I submit with option_collection = { opt: true } I don't run into this error.
}


jeads commented on 27 Feb:
{
Good catch! That's a bug, will add handling for an empty option_collection, it should definitely not be required.
}


geoelectric commented 23 days ago:
{
Ran into this too. camd helped me debug but was pretty mysterious.
}

Comment 1

[Cameron Dawson [:camd]]

Yeah, Geo ran into this, too.