1043423 - SDK's ui/toolbar element creates a border in Firefox 31

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Christopher Plantijn]

Attachment: toolbar.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/36.0.1985.125 Safari/537.36

Steps to reproduce:

Followed instructions on creating a toolbar via - https://developer.mozilla.org/en-US/Add-ons/SDK/Low-Level_APIs/ui_toolbar


Actual results:

The toolbar was created with a -moz-like  3d border around the edges. See Image included.


Expected results:

A clean ui toolbar that doesn't have the border.

Comment 2

[Dylan Sharhon]

Attachment: Add "border: 0" to existing toolbar style.

There are already no borders on Mac or Linux, just Windows. The original source of the border is

toolkit/themes/windows/global/toolbar.css:26-31
--------------------------------------------------------------------------------
...
toolbar {
  min-width: 1px;
  min-height: 19px;
  border-top: 1px solid ThreeDHighlight;
  border-bottom: 1px solid ThreeDShadow;
}
...
--------------------------------------------------------------------------------

but we can't change that because SeaMonkey (and Thunderbird?) still depend on that CSS property left over from the Firefox 3.x days.

However, addon toolbars are custom-styled in

addon-sdk/source/lib/sdk/ui/toolbar/view.js:99
--------------------------------------------------------------------------------
...
  view.setAttribute("style", "padding: 2px 0; max-height: 40px;");
...
--------------------------------------------------------------------------------

so it would be simplest to just add "border: 0;" to that line. :)

Comment 3

[Dylan Sharhon]

Attachment: noborder2.patch

Correction: it's the inner "hack" toolbar that needs its border removed, not the outer toolbar.

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8822292 [details] [diff] [review]
noborder2.patch

Looks good to me! Thanks for working on that.

Comment 5

[Carsten Book [:Tomcat]]

landed, thanks for contributing!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7875d24ddb7a
Fix "SDK's ui/toolbar element creates a border in Firefox 31" r=zer0

Comment 7

[Dylan Sharhon]

Awesome, thanks!

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7875d24ddb7a