1325891 - Firefox addon toolbars still have 3D borders

Status: RESOLVED DUPLICATE of bug 1043423

(Toolkit :: Themes, defect)

Description

[Dylan Sharhon]

Attachment: 3D border in Windows Classic and Aero themes.

Making a toolbar using the Add-on SDK:

require('sdk/ui').Toolbar({title: 'test'});

results in a toolbar with an inconsistent-looking 3D border left over from the now-unavailable Firefox 3 theme.

The border is not present in Mac or Linux.

Comment 1

[Dylan Sharhon]

I was thinking of making a patch in

toolkit/themes/windows/global/toolbar.css 
--------------------------------------------------------------------------------
...
toolbar {
  min-width: 1px;
  min-height: 19px;
  border-top: 1px solid ThreeDHighlight;
  border-bottom: 1px solid ThreeDShadow;
}
...
--------------------------------------------------------------------------------

by simply deleting the "border-top" and "border-bottom" lines the issue is fixed without side-effects in Firefox. Nothing in Firefox except add-on toolbars actually uses those CSS properties as far as I can tell. However, Seamonkey still uses them!

Comment 2

[Dylan Sharhon]

Attachment: Effect in Firefox of deleting border in toolbar.css

Comment 3

[Dylan Sharhon]

Ah, this bug fell through the cracks in 2014.