Closed Bug 1043535 Opened 10 years ago Closed 10 years ago

No-X builds: Variable LIBS is defined in /toolkit/library/build/Makefile. It should only be defined in moz.build files.

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1042685

People

(Reporter: gcp, Unassigned)

References

Details

Trying to compile current mozilla-central on Linux with X disabled: 
ac_add_options --without-x
ac_add_options --enable-default-toolkit=cairo-qt

 1:20.28 /home/morbo/hg/mozilla-central/config/config.mk:105: *** Variable LIBS is defined in /home/morbo/hg/mozilla-central/objdir-desktop/toolkit/library/build/Makefile. It should only be defined in moz.build files.  Stop.
 1:20.28 make[4]: *** [toolkit/library/build/export] Error 2

Bisected to:

The first bad revision is:
changeset:   195644:a0988e587a90
user:        Mike Hommey <mh+mozilla@glandium.org>
date:        Wed Jul 23 13:31:02 2014 +0900
summary:     Bug 1036894 part 9 - Replace all EXTRA_DSO_LDOPTS, SHARED_LIBRARY_LIBS and LIBS with EXTRA_LIBS, OS_LIBS or OS_LDFLAGS, appropriately. r=gps

Related to bug 1042525 and Bug 966814. (Patch for the latter from that bug may be needed, and this bug blocks resolution of the former)
Blocks: 1042525
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.