1043557 - Confirmation message is needed when clearing all the entries in the Call Log of the Loop Mobile application

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

According to the Acs described in User Story:

Bug 1007659 - [User Story] As a user I would like to be able to clear my Loop communication history (aka Call Log)

A confirmation message should be showed to the user before deleting all the entries in the Call Log.

This confirmation message is not implemented yet.

Comment 1

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Comment 2

[Borja Salguero [:borjasalguero]]

Comment on attachment 8463959 [details] [review]
Pull Request

This patch is solving as well:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1043552
- https://bugzilla.mozilla.org/show_bug.cgi?id=1043544

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8463959 [details] [review]
Pull Request

The patch looks good. I just left you a few comments on the PR and also found one functional issue:

- Share two urls
- Revoke one
- Clear revoked urls, cleans the correct url.
- Restart the app
- The revoked url is still listed but the other one is gone.

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8463959 [details] [review]
Pull Request

I would also like to hear Arnau's feedback regarding the HTML and CSS changes

Comment 7

[Borja Salguero [:borjasalguero]]

Comment on attachment 8463959 [details] [review]
Pull Request

In this case there is no modification CSS/HTML, I've just copy&paste the Building Block as it is, without any modification.

Comment 8

[mbarone]

Tested with Flame (v2.0 kk v180)
Gecko-9362b48.Gaia-6449cc3
Loop version 041ff17