1043624 - Style search term: IndexOutOfBoundsException: setSpan (7 ... 5) has end before start

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Search Activity, defect, P1)

Description

[Eric Edens [:eedens]]

Attachment: Stack trace

Intermittent crash while get search suggestions. Attached is a logcat stacktrace.

Repro steps aren't clear, but it seems to happen while typing / clearing rapidly.


(Followup to Bug 1029682.)

Comment 1

[:Margaret Leibovic]

Attachment: Set correct end for SpannableString

I wasn't able to reproduce this, but I looked into it and realized we were using this API incorrectly:
http://developer.android.com/reference/android/text/SpannableString.html#setSpan%28java.lang.Object,%20int,%20int,%20int%29

So, if the match isn't at the beginning of the string, we can run into this crash.

PR here: https://github.com/ericedens/FirefoxSearch/pull/34

Comment 2

[Eric Edens [:eedens]]

Comment on attachment 8462614 [details] [diff] [review]
Set correct end for SpannableString

Review of attachment 8462614 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/ceab6297c502

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ceab6297c502

Comment 5

[:Margaret Leibovic]

eedens, friendly reminder: you should link to FirefoxSearch commits when you merge them. I just had to double check that this patch made it in:

https://github.com/ericedens/FirefoxSearch/commit/648dae0c94391ba179d1b3adbaf30a5b243f6228